update coding guideline

vdaas · Sep 17, 2020 · 83fe277 · 83fe277
1 parent 28d24ce
commit 83fe277
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/docs/contributing/coding-style.md b/docs/contributing/coding-style.md
@@ -546,7 +546,9 @@ func New(opts ...Option) (Server, error) {
     for _, opt := range opts {
         if err := opt(srv); err != nil {
             werr := errors.ErrOptionFailed(err, reflect.ValueOf(opt))
-            if errors.IsCriticalOptionError(err) {
+
+            e := new(errors.ErrCriticalOption)
+			if errors.As(err, &e) {
                 log.Error(werr)
                 return nil, werr
             }