fix benchmark timers

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>
vdaas · Aug 27, 2020 · 9655fcd · 9655fcd
1 parent 1a6c589
commit 9655fcd
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/hack/benchmark/core/benchmark/strategy/bulk_insert.go b/hack/benchmark/core/benchmark/strategy/bulk_insert.go
@@ -50,8 +50,11 @@ func NewBulkInsert(opts ...StrategyOption) benchmark.Strategy {
 					}
 					v = append(v, arr.([]float32))
 				}
+
+				b.StopTimer()
+				b.ReportAllocs()
+				b.ResetTimer()
 				b.StartTimer()
-				defer b.StopTimer()
 				ids, errs := c.BulkInsert(v)
 				return ids, wrapErrors(errs)
 			},
@@ -73,8 +76,11 @@ func NewBulkInsert(opts ...StrategyOption) benchmark.Strategy {
 					}
 					v = append(v, float32To64(arr.([]float32)))
 				}
+
+				b.StopTimer()
+				b.ReportAllocs()
+				b.ResetTimer()
 				b.StartTimer()
-				defer b.StopTimer()
 				ids, errs := c.BulkInsert(v)
 				return ids, wrapErrors(errs)
 			},

diff --git a/hack/benchmark/core/benchmark/strategy/bulk_insert_commit.go b/hack/benchmark/core/benchmark/strategy/bulk_insert_commit.go
@@ -46,8 +46,11 @@ func NewBulkInsertCommit(poolSize uint32, opts ...StrategyOption) benchmark.Stra
 					}
 					v = append(v, arr.([]float32))
 				}
+
+				b.StopTimer()
+				b.ReportAllocs()
+				b.ResetTimer()
 				b.StartTimer()
-				defer b.StopTimer()
 				ids, errs := c.BulkInsertCommit(v, poolSize)
 				return ids, wrapErrors(errs)
 			},
@@ -69,8 +72,11 @@ func NewBulkInsertCommit(poolSize uint32, opts ...StrategyOption) benchmark.Stra
 					}
 					v = append(v, float32To64(arr.([]float32)))
 				}
+
+				b.StopTimer()
+				b.ReportAllocs()
+				b.ResetTimer()
 				b.StartTimer()
-				defer b.StopTimer()
 				ids, errs := c.BulkInsertCommit(v, poolSize)
 				return ids, wrapErrors(errs)
 			},