fix

vdaas · Dec 23, 2024 · a0c9435 · a0c9435
1 parent a2ca0c2
commit a0c9435
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/.github/actions/e2e-deploy-vald-readreplica/action.yaml b/.github/actions/e2e-deploy-vald-readreplica/action.yaml
@@ -85,10 +85,13 @@ runs:
       run: |
         make k8s/vald-readreplica/deploy HELM_VALUES=${VALUES} HELM_EXTRA_OPTIONS="${HELM_EXTRA_OPTIONS}"
 
+        kubectl logs -l app=vald-lb-gateway > gateway.log &
         sleep 3
 
         kubectl get pods
 
+        kubectl wait --for=condition=ready pod -l ${WAIT_FOR_SELECTOR} --timeout=600s
+
         podname=`kubectl get pods --selector=${WAIT_FOR_SELECTOR} | tail -1 | awk '{print $1}'`
         echo "POD_NAME=${podname}" >> $GITHUB_OUTPUT
       env:

diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml
@@ -341,6 +341,10 @@ jobs:
             e2e/readreplica
         env:
           POD_NAME: ${{ steps.deploy_vald.outputs.POD_NAME }}
+      - name: output logs on failure
+        if: failure()
+        run: |
+          cat ./gateway.log
   e2e-stream-crud-with-mirror:
     name: "E2E test (Stream CRUD) with mirror"
     needs: [detect-ci-container]

diff --git a/Makefile.d/k8s.mk b/Makefile.d/k8s.mk
@@ -267,7 +267,6 @@ k8s/vald-readreplica/deploy: k8s/vald/deploy
 	kubectl apply -f $(TEMP_DIR)/vald/templates/gateway/lb || true
 
 	kubectl get pods
-	kubectl wait --for=condition=ready pod -l app=vald-lb-gateway --timeout=600s
 
 .PHONY: k8s/vald-readreplica/delete
 ## delete vald-helm-operator from k8s