Fix e2e-bench-agent CI to fail correctly (#800)

* ♻️ refactor Make tasks for e2e-bench-agent Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> * 💚 use checkout@v2 Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> * ✨ upload artifacts on e2e bench agent tests Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> * 💚 run e2e bench agent for internal/net changes Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> * ✏️ fix typo Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
vdaas · Oct 28, 2020 · baeb365 · baeb365
1 parent 5e2c8bb
commit baeb365
Show file tree

Hide file tree

Showing 22 changed files with 300 additions and 189 deletions.
diff --git a/.github/workflows/build-protobuf.yml b/.github/workflows/build-protobuf.yml
@@ -18,9 +18,7 @@ jobs:
     container:
       image: vdaas/vald-ci-container:nightly
     steps:
-      - uses: actions/checkout@v1
-        with:
-          fetch-depth: 10
+      - uses: actions/checkout@v2
       - name: build protobuf
         run: |
           make proto/all
diff --git a/.github/workflows/chatops.yml b/.github/workflows/chatops.yml
@@ -95,7 +95,7 @@ jobs:
         env:
           USERNAME: ${{ steps.check_comments_changelog.outputs.COMMENTER_USERNAME }}
           REQUIRED_POLICY: changelog
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
         if: steps.check_comments_changelog.outputs.BOOL_TRIGGERED == 'true' && steps.check_permissions.outputs.EXECUTABLE == 'true'
         with:
           fetch-depth: 0
@@ -170,7 +170,7 @@ jobs:
           API_URL: ${{ github.event.issue.comments_url }}
           BRANCH: ${{ steps.check_comments_rebase.outputs.BRANCH_NAME }}
           USERNAME: ${{ steps.check_comments_rebase.outputs.COMMENTER_USERNAME }}
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
         if: steps.check_comments_rebase.outputs.BOOL_TRIGGERED == 'true' && steps.check_permissions.outputs.EXECUTABLE == 'true'
       - name: Automatic Rebase
         if: steps.check_comments_rebase.outputs.BOOL_TRIGGERED == 'true' && steps.check_permissions.outputs.EXECUTABLE == 'true'
@@ -244,10 +244,8 @@ jobs:
           USERNAME: ${{ steps.check_comments_gen_test.outputs.COMMENTER_USERNAME }}
           PR_AUTHOR: ${{ github.event.issue.user.login }}
           API_URL: ${{ github.event.issue.comments_url }}
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
         if: steps.check_comments_gen_test.outputs.BOOL_TRIGGERED == 'true' && steps.check_permissions.outputs.EXECUTABLE == 'true'
-        with:
-          fetch-depth: 10
       - name: Generate tests and push
         if: steps.check_comments_gen_test.outputs.BOOL_TRIGGERED == 'true' && steps.check_permissions.outputs.EXECUTABLE == 'true'
         run: |
@@ -350,10 +348,8 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.DISPATCH_TOKEN }}
           USERNAME: ${{ steps.check_comments_format.outputs.COMMENTER_USERNAME }}
           API_URL: ${{ github.event.issue.comments_url }}
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
         if: steps.check_comments_format.outputs.BOOL_TRIGGERED == 'true' && steps.check_permissions.outputs.EXECUTABLE == 'true'
-        with:
-          fetch-depth: 10
       - name: Fetch golang version
         if: steps.check_comments_format.outputs.BOOL_TRIGGERED == 'true' && steps.check_permissions.outputs.EXECUTABLE == 'true'
         run: |

diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
@@ -23,9 +23,7 @@ jobs:
       image: vdaas/vald-ci-container:nightly
     steps:
       - name: Check out code.
-        uses: actions/checkout@v1
-        with:
-          fetch-depth: 10
+        uses: actions/checkout@v2
       - name: Run coverage
         continue-on-error: true
         run: |

diff --git a/.github/workflows/dockers-image-scan.yml b/.github/workflows/dockers-image-scan.yml
@@ -7,9 +7,7 @@ jobs:
   agent-ngt:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-        with:
-          fetch-depth: 2
+      - uses: actions/checkout@v2
       - name: Build the Docker image
         id: build_image
         run: |
@@ -39,9 +37,7 @@ jobs:
   agent-sidecar:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-        with:
-          fetch-depth: 2
+      - uses: actions/checkout@v2
       - name: Build the Docker image
         id: build_image
         run: |
@@ -71,9 +67,7 @@ jobs:
   discoverer-k8s:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-        with:
-          fetch-depth: 2
+      - uses: actions/checkout@v2
       - name: Build the Docker image
         id: build_image
         run: |
@@ -103,9 +97,7 @@ jobs:
   gateway-vald:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-        with:
-          fetch-depth: 2
+      - uses: actions/checkout@v2
       - name: Build the Docker image
         id: build_image
         run: |
@@ -135,9 +127,7 @@ jobs:
   meta-redis:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-        with:
-          fetch-depth: 2
+      - uses: actions/checkout@v2
       - name: Build the Docker image
         id: build_image
         run: |
@@ -167,9 +157,7 @@ jobs:
   meta-cassandra:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-        with:
-          fetch-depth: 2
+      - uses: actions/checkout@v2
       - name: Build the Docker image
         id: build_image
         run: |
@@ -199,9 +187,7 @@ jobs:
   backup-manager-mysql:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-        with:
-          fetch-depth: 2
+      - uses: actions/checkout@v2
       - name: Build the Docker image
         id: build_image
         run: |
@@ -231,9 +217,7 @@ jobs:
   backup-manager-cassandra:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-        with:
-          fetch-depth: 2
+      - uses: actions/checkout@v2
       - name: Build the Docker image
         id: build_image
         run: |
@@ -263,9 +247,7 @@ jobs:
   compressor:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-        with:
-          fetch-depth: 2
+      - uses: actions/checkout@v2
       - name: Build the Docker image
         id: build_image
         run: |
@@ -295,9 +277,7 @@ jobs:
   manager-index:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-        with:
-          fetch-depth: 2
+      - uses: actions/checkout@v2
       - name: Build the Docker image
         id: build_image
         run: |
@@ -327,9 +307,7 @@ jobs:
   operator-helm:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-        with:
-          fetch-depth: 2
+      - uses: actions/checkout@v2
       - name: Build the Docker image
         id: build_image
         run: |
@@ -359,9 +337,7 @@ jobs:
   loadtest:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-        with:
-          fetch-depth: 2
+      - uses: actions/checkout@v2
       - name: Build the Docker image
         id: build_image
         run: |

diff --git a/.github/workflows/e2e-bench-agent.yml b/.github/workflows/e2e-bench-agent.yml
@@ -5,10 +5,9 @@ on:
       - master
     paths:
       - ".github/workflows/e2e-bench-agent.yml"
-      - "internal/**"
-      - "!internal/**/*_test.go"
-      - "!internal/db/**"
-      - "!internal/k8s/**"
+      - "internal/core/**"
+      - "internal/client/**"
+      - "internal/net/**"
       - "apis/grpc/**"
       - "pkg/agent/core/ngt/**"
       - "cmd/agent/core/ngt/**"
@@ -18,10 +17,9 @@ on:
   pull_request:
     paths:
       - ".github/workflows/e2e-bench-agent.yml"
-      - "internal/**"
-      - "!internal/**/*_test.go"
-      - "!internal/db/**"
-      - "!internal/k8s/**"
+      - "internal/core/**"
+      - "internal/client/**"
+      - "internal/net/**"
       - "apis/grpc/**"
       - "pkg/agent/core/ngt/**"
       - "cmd/agent/core/ngt/**"
@@ -37,12 +35,21 @@ jobs:
       image: vdaas/vald-ci-container:nightly
     steps:
       - name: Check out code.
-        uses: actions/checkout@v1
-        with:
-          fetch-depth: 1
+        uses: actions/checkout@v2
       - name: Run grpc-sequential
         run: |
           make bench/agent/sequential/grpc
+      - name: Upload artifact
+        uses: actions/upload-artifact@v2
+        with:
+          name: agent-sequential-grpc
+          path: |
+            ./pprof/agent/sequential/grpc.bin
+            ./pprof/agent/sequential/grpc.cpu.out
+            ./pprof/agent/sequential/grpc.mem.out
+            ./pprof/agent/sequential/grpc.trace.out
+            ./pprof/agent/sequential/grpc.cpu.svg
+            ./pprof/agent/sequential/grpc.mem.svg
 
   grpc-stream:
     name: grpc-stream
@@ -51,12 +58,21 @@ jobs:
       image: vdaas/vald-ci-container:nightly
     steps:
       - name: Check out code.
-        uses: actions/checkout@v1
-        with:
-          fetch-depth: 1
+        uses: actions/checkout@v2
       - name: Run grpc-stream
         run: |
           make bench/agent/stream
+      - name: Upload artifact
+        uses: actions/upload-artifact@v2
+        with:
+          name: agent-stream
+          path: |
+            ./pprof/agent/stream.bin
+            ./pprof/agent/stream.cpu.out
+            ./pprof/agent/stream.mem.out
+            ./pprof/agent/stream.trace.out
+            ./pprof/agent/stream.cpu.svg
+            ./pprof/agent/stream.mem.svg
 
   rest:
     name: rest
@@ -65,9 +81,18 @@ jobs:
       image: vdaas/vald-ci-container:nightly
     steps:
       - name: Check out code.
-        uses: actions/checkout@v1
-        with:
-          fetch-depth: 1
+        uses: actions/checkout@v2
       - name: Run rest
         run: |
           make bench/agent/sequential/rest
+      - name: Upload artifact
+        uses: actions/upload-artifact@v2
+        with:
+          name: agent-sequential-rest
+          path: |
+            ./pprof/agent/sequential/rest.bin
+            ./pprof/agent/sequential/rest.cpu.out
+            ./pprof/agent/sequential/rest.mem.out
+            ./pprof/agent/sequential/rest.trace.out
+            ./pprof/agent/sequential/rest.cpu.svg
+            ./pprof/agent/sequential/rest.mem.svg
diff --git a/.github/workflows/e2e-deploy.yml b/.github/workflows/e2e-deploy.yml
@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 45
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - name: wait for dockers
         run: |
           tag=$(cat versions/VALD_VERSION)

diff --git a/.github/workflows/helm-lint.yml b/.github/workflows/helm-lint.yml
@@ -12,9 +12,7 @@ jobs:
       image: vdaas/vald-ci-container:nightly
     steps:
       - name: Check out code.
-        uses: actions/checkout@v1
-        with:
-          fetch-depth: 1
+        uses: actions/checkout@v2
       - name: Helm version
         run: |
           helm version
@@ -31,9 +29,7 @@ jobs:
       image: vdaas/vald-ci-container:nightly
     steps:
       - name: Check out code.
-        uses: actions/checkout@v1
-        with:
-          fetch-depth: 1
+        uses: actions/checkout@v2
       - name: Helm version
         run: |
           helm version

diff --git a/.github/workflows/helm.yml b/.github/workflows/helm.yml
@@ -15,9 +15,7 @@ jobs:
       image: vdaas/vald-ci-container:nightly
     steps:
       - name: Check out code.
-        uses: actions/checkout@v1
-        with:
-          fetch-depth: 10
+        uses: actions/checkout@v2
       - name: Helm version
         run: |
           helm version
@@ -68,9 +66,7 @@ jobs:
       image: vdaas/vald-ci-container:nightly
     steps:
       - name: Check out code.
-        uses: actions/checkout@v1
-        with:
-          fetch-depth: 10
+        uses: actions/checkout@v2
       - name: Helm version
         run: |
           helm version

diff --git a/.github/workflows/reviewdog-hadolint.yml b/.github/workflows/reviewdog-hadolint.yml
@@ -25,7 +25,7 @@ jobs:
     name: runner / hadolint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - name: hadolint
         uses: reviewdog/action-hadolint@v1
         with:

diff --git a/.github/workflows/reviewdog-markdown.yml b/.github/workflows/reviewdog-markdown.yml
@@ -26,7 +26,7 @@ jobs:
     name: runner / LanguageTool
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - name: LanguageTool
         uses: reviewdog/action-languagetool@v1
         with:

diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml
@@ -27,7 +27,7 @@ jobs:
     container:
       image: vdaas/vald-ci-container:nightly
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - name: go build
         run: |
           go build ./...

diff --git a/.github/workflows/semver.yml b/.github/workflows/semver.yml
@@ -12,7 +12,7 @@ jobs:
       image: vdaas/vald-ci-container:nightly
     steps:
       - name: Check out code.
-        uses: actions/checkout@v1
+        uses: actions/checkout@v2
         with:
           fetch-depth: 0
       - name: Get latest gitwerk