Skip to content

Commit

Permalink
Fix race error of server package (#1689)
Browse files Browse the repository at this point in the history
* fix race error and deleted duplicate test function

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* apply suggestion

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* apply suggestion

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* Apply suggestions from code review

Co-authored-by: Kevin Diu <kevindiujp@gmail.com>

* fix deepsource warning

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
  • Loading branch information
hlts2 and kevindiu committed Jun 6, 2022
1 parent 528b937 commit bcaac99
Show file tree
Hide file tree
Showing 3 changed files with 139 additions and 1,116 deletions.
3 changes: 2 additions & 1 deletion internal/servers/option_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
package servers

import (
"context"
"reflect"
"testing"
"time"
Expand Down Expand Up @@ -97,7 +98,7 @@ func TestWithErrorGroup(t *testing.T) {

tests := []test{
func() test {
eg := errgroup.Get()
eg, _ := errgroup.New(context.Background())

return test{
name: "set success",
Expand Down
Loading

0 comments on commit bcaac99

Please sign in to comment.