Skip to content

Commit

Permalink
Update Dockerfile to use official debian based image for devcontainer
Browse files Browse the repository at this point in the history
  • Loading branch information
ykadowak committed Feb 8, 2024
1 parent 84c8434 commit d59583c
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion dockers/dev/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
ARG MAINTAINER="vdaas.org vald team <vald@vdaas.org>"

# skipcq: DOK-DL3026
FROM --platform=${BUILDPLATFORM} ubuntu:devel AS builder
# Ubuntu is not supported by a lot of devcontainer features like `docker-in-docker`, so we should stick to official debian based ones
# https://github.com/devcontainers/features/blob/08fb370a59cc311d9f81a9e90be33cf2e6648baa/src/docker-in-docker/install.sh#L123
# FIXME: change the tag to :1 when they support go 1.22
FROM --platform=${BUILDPLATFORM} mcr.microsoft.com/vscode/devcontainers/go:dev-1.22 AS builder
LABEL maintainer="${MAINTAINER}"

ARG GO_VERSION
Expand Down

0 comments on commit d59583c

Please sign in to comment.