♻️ apply feedback

Signed-off-by: vankichi <kyukawa315@gmail.com>
vdaas · Sep 8, 2022 · efbfd13 · efbfd13
1 parent b115100
commit efbfd13
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/internal/k8s/benchmark/job/job.go b/internal/k8s/benchmark/job/job.go
@@ -42,6 +42,7 @@ type reconciler struct {
 func New(opts ...Option) BenchmarkJobWatcher {
 	r := new(reconciler)
 	for _, opt := range append(defaultOpts, opts...) {
+		// TODO: impl error handling after implement functional option
 		opt(r)
 	}
 	return r

diff --git a/internal/k8s/benchmark/operator/operator.go b/internal/k8s/benchmark/operator/operator.go
@@ -42,6 +42,7 @@ type reconciler struct {
 func New(opts ...Option) BenchmarkOperatorWatcher {
 	r := new(reconciler)
 	for _, opt := range append(defaultOpts, opts...) {
+		// TODO: impl error handling after implement functional option
 		opt(r)
 	}
 	return r

diff --git a/internal/k8s/benchmark/operator/types.go b/internal/k8s/benchmark/operator/types.go
@@ -31,9 +31,9 @@ type BenchmarkOperatorSpec struct {
 type BenchmarkOperatorStatus string
 
 const (
-	BenchmarkOperatorNotReady  = BenchmarkOperatorStatus("NotReady")
-	BenchmarkOperatorAvailable = BenchmarkOperatorStatus("Available")
-	BenchmarkOperatorHealthy   = BenchmarkOperatorStatus("Healthy")
+	BenchmarkOperatorNotReady  BenchmarkOperatorStatus = "NotReady"
+	BenchmarkOperatorAvailable BenchmarkOperatorStatus = "Available"
+	BenchmarkOperatorHealthy   BenchmarkOperatorStatus = "Healthy"
 )
 
 type BenchmarkOperator struct {