use config.GRPCClient.ConnectionPool.ResolveDNS

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>
vdaas · Sep 9, 2020 · f31bd51 · f31bd51
1 parent a6c3d8f
commit f31bd51
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/cmd/tools/cli/loadtest/sample.yaml b/cmd/tools/cli/loadtest/sample.yaml
@@ -27,7 +27,6 @@ dataset: fashion-mnist
 concurrency: 100
 batch_size: 10
 progress_duration: 3s
-resolve_dns: false
 addr: "localhost:8082"
 client:
   addrs: []
@@ -45,6 +44,8 @@ client:
     max_retry_rpc_buffer_size: 0
     max_send_msg_size: 0
     wait_for_ready: true
+  connection_pool:
+    enable_dns_resolver: true
   dial_option:
     enable_backoff: false
     initial_connection_window_size: 0

diff --git a/pkg/tools/cli/loadtest/config/config.go b/pkg/tools/cli/loadtest/config/config.go
@@ -115,7 +115,6 @@ type Data struct {
 	Concurrency         int                `json:"concurrency" yaml:"concurrency"`
 	BatchSize           int                `json:"batch_size" yaml:"batch_size"`
 	ProgressDuration    string             `json:"progress_duration" yaml:"progress_duration"`
-	ResolveDNS          bool               `json:"resolve_dns" yaml:"resolve_dns"`
 	Client              *config.GRPCClient `json:"client" yaml:"client"`
 }
 

diff --git a/pkg/tools/cli/loadtest/usecase/load.go b/pkg/tools/cli/loadtest/usecase/load.go
@@ -45,7 +45,6 @@ func New(cfg *config.Data) (r runner.Runner, err error) {
 		cfg.Client.Opts(),
 		grpc.WithAddrs(cfg.Addr),
 		grpc.WithErrGroup(run.eg),
-		grpc.WithResolveDNS(cfg.ResolveDNS),
 	)
 	run.client = grpc.New(clientOpts...)