Skip to content

Commit

Permalink
Revert "Add timestamp field to Object.Vector (#2136)"
Browse files Browse the repository at this point in the history
This reverts commit f35756b.
  • Loading branch information
ykadowak committed Nov 30, 2023
1 parent 7732afb commit fa80573
Show file tree
Hide file tree
Showing 39 changed files with 589 additions and 737 deletions.
229 changes: 114 additions & 115 deletions apis/docs/v1/docs.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apis/grpc/v1/agent/core/agent.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/grpc/v1/agent/sidecar/sidecar.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/grpc/v1/discoverer/discoverer.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/grpc/v1/filter/egress/egress_filter.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/grpc/v1/filter/ingress/ingress_filter.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/grpc/v1/manager/index/index_manager.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

259 changes: 124 additions & 135 deletions apis/grpc/v1/payload/payload.pb.go

Large diffs are not rendered by default.

33 changes: 1 addition & 32 deletions apis/grpc/v1/payload/payload_vtproto.pb.go
Original file line number Diff line number Diff line change
Expand Up @@ -934,8 +934,7 @@ func (m *Object_Vector) CloneVT() *Object_Vector {
return (*Object_Vector)(nil)
}
r := &Object_Vector{
Id: m.Id,
Timestamp: m.Timestamp,
Id: m.Id,
}
if rhs := m.Vector; rhs != nil {
tmpContainer := make([]float32, len(rhs))
Expand Down Expand Up @@ -2775,9 +2774,6 @@ func (this *Object_Vector) EqualVT(that *Object_Vector) bool {
return false
}
}
if this.Timestamp != that.Timestamp {
return false
}
return string(this.unknownFields) == string(that.unknownFields)
}

Expand Down Expand Up @@ -5743,11 +5739,6 @@ func (m *Object_Vector) MarshalToSizedBufferVT(dAtA []byte) (int, error) {
i -= len(m.unknownFields)
copy(dAtA[i:], m.unknownFields)
}
if m.Timestamp != 0 {
i = encodeVarint(dAtA, i, uint64(m.Timestamp))
i--
dAtA[i] = 0x18
}
if len(m.Vector) > 0 {
for iNdEx := len(m.Vector) - 1; iNdEx >= 0; iNdEx-- {
f1 := math.Float32bits(float32(m.Vector[iNdEx]))
Expand Down Expand Up @@ -7954,9 +7945,6 @@ func (m *Object_Vector) SizeVT() (n int) {
if len(m.Vector) > 0 {
n += 1 + sov(uint64(len(m.Vector)*4)) + len(m.Vector)*4
}
if m.Timestamp != 0 {
n += 1 + sov(uint64(m.Timestamp))
}
n += len(m.unknownFields)
return n
}
Expand Down Expand Up @@ -12992,25 +12980,6 @@ func (m *Object_Vector) UnmarshalVT(dAtA []byte) error {
} else {
return fmt.Errorf("proto: wrong wireType = %d for field Vector", wireType)
}
case 3:
if wireType != 0 {
return fmt.Errorf("proto: wrong wireType = %d for field Timestamp", wireType)
}
m.Timestamp = 0
for shift := uint(0); ; shift += 7 {
if shift >= 64 {
return ErrIntOverflow
}
if iNdEx >= l {
return io.ErrUnexpectedEOF
}
b := dAtA[iNdEx]
iNdEx++
m.Timestamp |= int64(b&0x7F) << shift
if b < 0x80 {
break
}
}
default:
iNdEx = preIndex
skippy, err := skip(dAtA[iNdEx:])
Expand Down
2 changes: 1 addition & 1 deletion apis/grpc/v1/vald/filter.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/grpc/v1/vald/insert.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/grpc/v1/vald/object.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/grpc/v1/vald/remove.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/grpc/v1/vald/search.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/grpc/v1/vald/update.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/grpc/v1/vald/upsert.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions apis/proto/v1/payload/payload.proto
Original file line number Diff line number Diff line change
Expand Up @@ -349,8 +349,6 @@ message Object {
string id = 1 [(validate.rules).string.min_len = 1];
// The vector.
repeated float vector = 2 [(validate.rules).repeated.min_items = 2];
// timestamp represents when this vector inserted.
int64 timestamp = 3;
}

// Represent multiple vectors.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,6 @@
"format": "float"
},
"description": "The vector."
},
"timestamp": {
"type": "string",
"format": "int64",
"description": "timestamp represents when this vector inserted."
}
},
"description": "Represent a vector."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,6 @@
"format": "float"
},
"description": "The vector."
},
"timestamp": {
"type": "string",
"format": "int64",
"description": "timestamp represents when this vector inserted."
}
},
"description": "Represent a vector."
Expand Down
4 changes: 2 additions & 2 deletions apis/swagger/v1/vald/apis/proto/v1/vald/filter.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -405,11 +405,11 @@
"code": {
"type": "integer",
"format": "int32",
"description": "The status code, which should be an enum value of\n[google.rpc.Code][google.rpc.Code]."
"description": "The status code, which should be an enum value of [google.rpc.Code][google.rpc.Code]."
},
"message": {
"type": "string",
"description": "A developer-facing error message, which should be in English. Any\nuser-facing error message should be localized and sent in the\n[google.rpc.Status.details][google.rpc.Status.details] field, or localized\nby the client."
"description": "A developer-facing error message, which should be in English. Any\nuser-facing error message should be localized and sent in the\n[google.rpc.Status.details][google.rpc.Status.details] field, or localized by the client."
},
"details": {
"type": "array",
Expand Down
9 changes: 2 additions & 7 deletions apis/swagger/v1/vald/apis/proto/v1/vald/insert.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,6 @@
"format": "float"
},
"description": "The vector."
},
"timestamp": {
"type": "string",
"format": "int64",
"description": "timestamp represents when this vector inserted."
}
},
"description": "Represent a vector."
Expand All @@ -156,11 +151,11 @@
"code": {
"type": "integer",
"format": "int32",
"description": "The status code, which should be an enum value of\n[google.rpc.Code][google.rpc.Code]."
"description": "The status code, which should be an enum value of [google.rpc.Code][google.rpc.Code]."
},
"message": {
"type": "string",
"description": "A developer-facing error message, which should be in English. Any\nuser-facing error message should be localized and sent in the\n[google.rpc.Status.details][google.rpc.Status.details] field, or localized\nby the client."
"description": "A developer-facing error message, which should be in English. Any\nuser-facing error message should be localized and sent in the\n[google.rpc.Status.details][google.rpc.Status.details] field, or localized by the client."
},
"details": {
"type": "array",
Expand Down
9 changes: 2 additions & 7 deletions apis/swagger/v1/vald/apis/proto/v1/vald/object.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,6 @@
"format": "float"
},
"description": "The vector."
},
"timestamp": {
"type": "string",
"format": "int64",
"description": "timestamp represents when this vector inserted."
}
},
"description": "Represent a vector."
Expand All @@ -149,11 +144,11 @@
"code": {
"type": "integer",
"format": "int32",
"description": "The status code, which should be an enum value of\n[google.rpc.Code][google.rpc.Code]."
"description": "The status code, which should be an enum value of [google.rpc.Code][google.rpc.Code]."
},
"message": {
"type": "string",
"description": "A developer-facing error message, which should be in English. Any\nuser-facing error message should be localized and sent in the\n[google.rpc.Status.details][google.rpc.Status.details] field, or localized\nby the client."
"description": "A developer-facing error message, which should be in English. Any\nuser-facing error message should be localized and sent in the\n[google.rpc.Status.details][google.rpc.Status.details] field, or localized by the client."
},
"details": {
"type": "array",
Expand Down
4 changes: 2 additions & 2 deletions apis/swagger/v1/vald/apis/proto/v1/vald/remove.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,11 @@
"code": {
"type": "integer",
"format": "int32",
"description": "The status code, which should be an enum value of\n[google.rpc.Code][google.rpc.Code]."
"description": "The status code, which should be an enum value of [google.rpc.Code][google.rpc.Code]."
},
"message": {
"type": "string",
"description": "A developer-facing error message, which should be in English. Any\nuser-facing error message should be localized and sent in the\n[google.rpc.Status.details][google.rpc.Status.details] field, or localized\nby the client."
"description": "A developer-facing error message, which should be in English. Any\nuser-facing error message should be localized and sent in the\n[google.rpc.Status.details][google.rpc.Status.details] field, or localized by the client."
},
"details": {
"type": "array",
Expand Down
4 changes: 2 additions & 2 deletions apis/swagger/v1/vald/apis/proto/v1/vald/search.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -391,11 +391,11 @@
"code": {
"type": "integer",
"format": "int32",
"description": "The status code, which should be an enum value of\n[google.rpc.Code][google.rpc.Code]."
"description": "The status code, which should be an enum value of [google.rpc.Code][google.rpc.Code]."
},
"message": {
"type": "string",
"description": "A developer-facing error message, which should be in English. Any\nuser-facing error message should be localized and sent in the\n[google.rpc.Status.details][google.rpc.Status.details] field, or localized\nby the client."
"description": "A developer-facing error message, which should be in English. Any\nuser-facing error message should be localized and sent in the\n[google.rpc.Status.details][google.rpc.Status.details] field, or localized by the client."
},
"details": {
"type": "array",
Expand Down
9 changes: 2 additions & 7 deletions apis/swagger/v1/vald/apis/proto/v1/vald/update.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,6 @@
"format": "float"
},
"description": "The vector."
},
"timestamp": {
"type": "string",
"format": "int64",
"description": "timestamp represents when this vector inserted."
}
},
"description": "Represent a vector."
Expand All @@ -156,11 +151,11 @@
"code": {
"type": "integer",
"format": "int32",
"description": "The status code, which should be an enum value of\n[google.rpc.Code][google.rpc.Code]."
"description": "The status code, which should be an enum value of [google.rpc.Code][google.rpc.Code]."
},
"message": {
"type": "string",
"description": "A developer-facing error message, which should be in English. Any\nuser-facing error message should be localized and sent in the\n[google.rpc.Status.details][google.rpc.Status.details] field, or localized\nby the client."
"description": "A developer-facing error message, which should be in English. Any\nuser-facing error message should be localized and sent in the\n[google.rpc.Status.details][google.rpc.Status.details] field, or localized by the client."
},
"details": {
"type": "array",
Expand Down
9 changes: 2 additions & 7 deletions apis/swagger/v1/vald/apis/proto/v1/vald/upsert.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,6 @@
"format": "float"
},
"description": "The vector."
},
"timestamp": {
"type": "string",
"format": "int64",
"description": "timestamp represents when this vector inserted."
}
},
"description": "Represent a vector."
Expand All @@ -156,11 +151,11 @@
"code": {
"type": "integer",
"format": "int32",
"description": "The status code, which should be an enum value of\n[google.rpc.Code][google.rpc.Code]."
"description": "The status code, which should be an enum value of [google.rpc.Code][google.rpc.Code]."
},
"message": {
"type": "string",
"description": "A developer-facing error message, which should be in English. Any\nuser-facing error message should be localized and sent in the\n[google.rpc.Status.details][google.rpc.Status.details] field, or localized\nby the client."
"description": "A developer-facing error message, which should be in English. Any\nuser-facing error message should be localized and sent in the\n[google.rpc.Status.details][google.rpc.Status.details] field, or localized by the client."
},
"details": {
"type": "array",
Expand Down
Loading

0 comments on commit fa80573

Please sign in to comment.