-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test for internal/errors/runner #1007
Conversation
[CHATOPS:HELP] ChatOps commands.
|
tests := []test{ | ||
func() test { | ||
err := New("runner Start error") | ||
name := "gateway" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
string gateway
has 6 occurrences, make it a constant (goconst)
Codecov Report
@@ Coverage Diff @@
## master #1007 +/- ##
==========================================
+ Coverage 14.48% 14.67% +0.18%
==========================================
Files 494 495 +1
Lines 28300 28363 +63
==========================================
+ Hits 4098 4161 +63
+ Misses 23956 23953 -3
- Partials 246 249 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rebase |
[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-errors-runner-unit-test |
Signed-off-by: vankichi <kyukawa315@gmail.com>
b9606b8
to
6ba08aa
Compare
[FORMAT] Updating license headers and formatting go codes triggered by kevindiu. |
Signed-off-by: vdaas-ci <ci@vdaas.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by kevindiu.
tests := []test{ | ||
func() test { | ||
err := New("runner Start error") | ||
name := "gateway" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
string gateway
has 6 occurrences, make it a constant (goconst)
Signed-off-by: vankichi kyukawa315@gmail.com
Description:
I added the unit tests for
internal/errors/runner.go
Also, add a comment for each function of
internal/errors/runner.go
grammar check has passed.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: