-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorial to support v1 #1009
Conversation
Signed-off-by: vankichi <kyukawa315@gmail.com>
[CHATOPS:HELP] ChatOps commands.
|
Signed-off-by: vankichi <kyukawa315@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
LanguageTool
docs/tutorial/get-started.md|544 col 6| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Client
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/tutorial/get-started.md|549 col 17| Please add a punctuation mark at the end of paragraph. (PUNCTUATION_PARAGRAPH_END)
Suggestions: Index.
, Index!
, Index?
, Index:
, Index,
, Index;
Rule: https://community.languagetool.org/rule/show/PUNCTUATION_PARAGRAPH_END?lang=en-US
Category: PUNCTUATION
docs/tutorial/get-started.md|625 col 12| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: B
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/tutorial/get-started.md|635 col 15| If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Go
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
/rebase |
[REBASE] Rebase triggered by vankichi for branch: documentation/docs/update-tutorial-docs |
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
Signed-off-by: vankichi <kyukawa315@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others looks good to me.
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: vankichi kyukawa315@gmail.com
Description:
Update tutorial document for v1
changes are below:
docs/tutorial/get-started.md
anddocs/tutorial/agent-on-docker.md
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: