move internal/net/tcp package to internal/net package and support unix domain socket #1010

kpango · 2021-02-16T17:56:25Z

Signed-off-by: kpango kpango@vdaas.org

Description:

This PR includes 6 changes

merge internal/net/tcp package to internal/net
create new package internal/net/control for socket configuration
unix domain socket support
change helm chart related to 1&2&3
update Go version 1.16 for checking tcp connectivity for future go update
patch update k8s dependencies

Related Issue:

How Has This Been Tested?:

I executed make e2e command and checked all existing test has been passed.

Environment:

Go Version: 1.15.8
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.3

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

vdaas-ci · 2021-02-16T17:56:45Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

vdaas-ci · 2021-02-16T17:56:45Z

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

codecov · 2021-02-16T18:11:58Z

Codecov Report

Merging #1010 (8a20261) into master (878059d) will decrease coverage by 0.63%.
The diff coverage is 17.08%.

@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
- Coverage   14.90%   14.26%   -0.64%     
==========================================
  Files         497      494       -3     
  Lines       28400    28284     -116     
==========================================
- Hits         4232     4034     -198     
- Misses      23910    24000      +90     
+ Partials      258      250       -8

Impacted Files	Coverage Δ
hack/helm/schema/gen/main.go	`0.00% <0.00%> (ø)`
internal/client/v1/client/discoverer/discover.go	`0.00% <0.00%> (ø)`
internal/config/cassandra.go	`0.00% <0.00%> (ø)`
internal/config/client.go	`0.00% <0.00%> (ø)`
internal/config/discoverer.go	`0.00% <0.00%> (ø)`
internal/config/grpc.go	`0.00% <0.00%> (ø)`
internal/config/meta.go	`0.00% <0.00%> (ø)`
internal/config/redis.go	`0.00% <0.00%> (ø)`
internal/config/server.go	`0.00% <0.00%> (ø)`
internal/db/kvs/redis/option.go	`90.39% <ø> (ø)`
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878059d...4d93b47. Read the comment docs.

charts/vald/README.md

…x domain socket Signed-off-by: kpango <kpango@vdaas.org>

hack/helm/schema/gen/main.go

internal/net/dialer.go

internal/net/net.go

internal/net/dialer_test.go

internal/net/control/control.go

internal/net/grpc/option.go

internal/db/rdb/mysql/mysql.go

Signed-off-by: kpango <kpango@vdaas.org>

internal/net/net.go

github-actions · 2021-02-18T06:35:44Z

internal/net/net.go

+	localHost   = "localhost"
+	defaultPort = 80
+
+	Unknown NetworkType = iota


🚫 [golangci] _{reported by reviewdog 🐶}
exported const Unknown should have comment (or a comment on this block) or be unexported (golint)

internal/net/net.go

internal/net/dialer.go

internal/net/dialer_test.go

internal/net/net_test.go

internal/net/dialer_test.go

internal/net/option_test.go

kpango · 2021-02-18T07:19:07Z

@vdaas/core @vdaas/sre @vdaas/set This pr is now ready for review, please review this PR

Signed-off-by: kpango <kpango@vdaas.org>

internal/net/option_test.go

internal/net/dialer.go

internal/servers/server/option_test.go

internal/servers/server/server.go

Signed-off-by: kpango <kpango@vdaas.org>

internal/db/rdb/mysql/mysql.go

internal/net/net_test.go

Signed-off-by: kpango <kpango@vdaas.org>

internal/servers/server/option.go

internal/net/grpc/pool/pool.go

Signed-off-by: kpango <kpango@vdaas.org>

github-actions · 2021-02-19T03:05:18Z

internal/k8s/option_test.go

@@ -830,7 +830,7 @@ func TestWithDialer(t *testing.T) {
 	// Change interface type to the type of object you are testing
 	type T = interface{}
 	type args struct {
-		der tcp.Dialer
+		der net.Dialer


🚫 [golangci] _{reported by reviewdog 🐶}
der is unused (structcheck)

github-actions · 2021-02-19T03:05:18Z

internal/net/control/control.go

+	}
+}
+
+func (ctrl *control) GetControl() func(network, addr string, c syscall.RawConn) (err error) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function 'GetControl' is too long (78 > 60) (funlen)

vankichi

Thx ! Gread Job!
LGTM

rinx

checked.

…-to-net-package-and-support-unix-domain-socket

github-actions · 2021-02-19T04:17:31Z

internal/net/control/control_test.go

+//
+
+// Package control provides network socket option
+package control


🚫 [golangci] _{reported by reviewdog 🐶}
package should be control_test instead of control (testpackage)

kpango force-pushed the refactor/internal-net-tcp/move-tcp-package-to-net-package-and-support-unix-domain-socket branch from c3d60a7 to d51abb9 Compare February 16, 2021 17:56

github-actions bot added area/agent/sidecar area/discoverer area/helm area/internal team/set SET team size/XXL type/refactoring priority/low labels Feb 16, 2021

kpango force-pushed the refactor/internal-net-tcp/move-tcp-package-to-net-package-and-support-unix-domain-socket branch from d51abb9 to a6a1398 Compare February 17, 2021 08:59

github-actions bot reviewed Feb 17, 2021

View reviewed changes

kpango force-pushed the refactor/internal-net-tcp/move-tcp-package-to-net-package-and-support-unix-domain-socket branch 3 times, most recently from ff60577 to 1b49bc2 Compare February 18, 2021 05:04

move internal/net/tcp package to internal/net package and support uni…

e9ebdd1

…x domain socket Signed-off-by: kpango <kpango@vdaas.org>

kpango force-pushed the refactor/internal-net-tcp/move-tcp-package-to-net-package-and-support-unix-domain-socket branch 2 times, most recently from 41dde2c to eed9588 Compare February 18, 2021 06:03

github-actions bot reviewed Feb 18, 2021

View reviewed changes

fix failing test

ec820cb

Signed-off-by: kpango <kpango@vdaas.org>

kpango force-pushed the refactor/internal-net-tcp/move-tcp-package-to-net-package-and-support-unix-domain-socket branch from eed9588 to ec820cb Compare February 18, 2021 06:28

github-actions bot reviewed Feb 18, 2021

View reviewed changes

kpango changed the title ~~[WIP] move internal/net/tcp package to internal/net package and support unix domain socket~~ move internal/net/tcp package to internal/net package and support unix domain socket Feb 18, 2021

fix helm chart missing value

48e06ab

Signed-off-by: kpango <kpango@vdaas.org>

kpango requested review from a team February 18, 2021 07:52

kpango requested review from rinx, kevindiu, vankichi, datelier and hlts2 and removed request for a team February 18, 2021 07:52

github-actions bot reviewed Feb 18, 2021

View reviewed changes

add tcp dial trace span & more strict tls server listen validation

8170eed

Signed-off-by: kpango <kpango@vdaas.org>

vankichi reviewed Feb 19, 2021

View reviewed changes

internal/db/rdb/mysql/mysql.go Show resolved Hide resolved

internal/db/rdb/mysql/mysql.go Outdated Show resolved Hide resolved

internal/net/net_test.go Outdated Show resolved Hide resolved

fix commented out test

764ac42

Signed-off-by: kpango <kpango@vdaas.org>

github-actions bot added area/makefile team/sre SRE team labels Feb 19, 2021

github-actions bot reviewed Feb 19, 2021

View reviewed changes

cover mysql_test for unix domain socket

3a0646b

Signed-off-by: kpango <kpango@vdaas.org>

kpango force-pushed the refactor/internal-net-tcp/move-tcp-package-to-net-package-and-support-unix-domain-socket branch from 8a20261 to 3a0646b Compare February 19, 2021 02:58

github-actions bot reviewed Feb 19, 2021

View reviewed changes

vankichi approved these changes Feb 19, 2021

View reviewed changes

rinx approved these changes Feb 19, 2021

View reviewed changes

hlts2 approved these changes Feb 19, 2021

View reviewed changes

Merge branch 'master' into refactor/internal-net-tcp/move-tcp-package…

4d93b47

…-to-net-package-and-support-unix-domain-socket

kpango merged commit 27752bd into master Feb 19, 2021

kpango deleted the refactor/internal-net-tcp/move-tcp-package-to-net-package-and-support-unix-domain-socket branch February 19, 2021 04:10

github-actions bot reviewed Feb 19, 2021

View reviewed changes

vdaas-ci mentioned this pull request Feb 19, 2021

[patch] v1.0.3 release #1026

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move internal/net/tcp package to internal/net package and support unix domain socket #1010

move internal/net/tcp package to internal/net package and support unix domain socket #1010

kpango commented Feb 16, 2021 •

edited

Loading

vdaas-ci commented Feb 16, 2021

vdaas-ci commented Feb 16, 2021

codecov bot commented Feb 16, 2021 •

edited

Loading

github-actions bot Feb 18, 2021

kpango commented Feb 18, 2021

github-actions bot Feb 19, 2021

github-actions bot Feb 19, 2021

vankichi left a comment

rinx left a comment

github-actions bot Feb 19, 2021

move internal/net/tcp package to internal/net package and support unix domain socket #1010

move internal/net/tcp package to internal/net package and support unix domain socket #1010

Conversation

kpango commented Feb 16, 2021 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vdaas-ci commented Feb 16, 2021

vdaas-ci commented Feb 16, 2021

codecov bot commented Feb 16, 2021 • edited Loading

Codecov Report

github-actions bot Feb 18, 2021

Choose a reason for hiding this comment

kpango commented Feb 18, 2021

github-actions bot Feb 19, 2021

Choose a reason for hiding this comment

github-actions bot Feb 19, 2021

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

rinx left a comment

Choose a reason for hiding this comment

github-actions bot Feb 19, 2021

Choose a reason for hiding this comment

kpango commented Feb 16, 2021 •

edited

Loading

codecov bot commented Feb 16, 2021 •

edited

Loading