Revise gRPC error statuses and details in meta (Redis/Cassandra) #1013

rinx · 2021-02-17T09:00:08Z

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

Added gRPC error details in meta Redis/Cassandra.

Reference:

https://github.com/googleapis/googleapis/blob/master/google/rpc/error_details.proto

Related Issue:

Nothing

How Has This Been Tested?:

Nothing

Environment:

Go Version: 1.16
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.3

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

vdaas-ci · 2021-02-17T09:00:28Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

codecov · 2021-02-17T09:06:26Z

Codecov Report

Merging #1013 (cd70f0f) into master (0beb8ae) will decrease coverage by 1.21%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
- Coverage   15.25%   14.04%   -1.22%     
==========================================
  Files         498      495       -3     
  Lines       28770    29190     +420     
==========================================
- Hits         4389     4099     -290     
- Misses      24110    24835     +725     
+ Partials      271      256      -15

Impacted Files	Coverage Δ
pkg/meta/cassandra/handler/grpc/handler.go	`0.00% <0.00%> (ø)`
pkg/meta/redis/handler/grpc/handler.go	`0.00% <0.00%> (ø)`
internal/config/config.go	`14.00% <0.00%> (-82.00%)`	⬇️
internal/errgroup/group.go	`92.42% <0.00%> (-1.52%)`	⬇️
internal/worker/worker.go	`83.33% <0.00%> (-1.05%)`	⬇️
internal/net/option.go
internal/net/dialer.go
internal/net/net.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777c96e...005a064. Read the comment docs.

github-actions · 2021-02-17T09:06:39Z

pkg/meta/redis/handler/grpc/handler.go

@@ -160,10 +249,21 @@
 	err = s.redis.Set(ctx, kv.GetKey(), kv.GetVal())
 	if err != nil {
 		log.Errorf("[SetMeta]\tunknown error\t%+v", err)
+		err = status.WrapWithInternal(fmt.Sprintf("SetMeta API failed to store: key %s val %s", kv.GetKey(), kv.GetVal()), err,


🚫 [golangci] _{reported by reviewdog 🐶}
line is 121 characters (lll)

github-actions · 2021-02-24T09:02:21Z

pkg/meta/cassandra/handler/grpc/handler.go

 		default:
 			log.Errorf("[GetMetasInverse]\tunknown error\t%+v", err)
+			err = status.WrapWithUnknown(fmt.Sprintf("GetMetasInverse API: unknown error occurred: vals %#v", vals.GetVals()), err,


🚫 [golangci] _{reported by reviewdog 🐶}
line is 122 characters (lll)

github-actions · 2021-02-24T09:02:21Z

pkg/meta/cassandra/handler/grpc/handler.go

@@ -200,10 +325,21 @@ func (s *server) SetMeta(ctx context.Context, kv *payload.Meta_KeyVal) (_ *paylo
 	err = s.cassandra.Set(kv.GetKey(), kv.GetVal())
 	if err != nil {
 		log.Errorf("[SetMeta]\tunknown error\t%+v", err)
+		err = status.WrapWithInternal(fmt.Sprintf("SetMeta API: failed to store: key %s val %s", kv.GetKey(), kv.GetVal()), err,


🚫 [golangci] _{reported by reviewdog 🐶}
line is 122 characters (lll)

github-actions · 2021-02-24T09:02:21Z

pkg/meta/cassandra/handler/grpc/handler.go

 		case errors.IsErrCassandraUnavailable(err):
 			log.Warnf("[DeleteMetas]\tunavailable\t%+v", err)
+			err = status.WrapWithUnavailable(fmt.Sprintf("DeleteMetas API: Cassandra unavailable: keys %#v", keys.GetKeys()), err,


🚫 [golangci] _{reported by reviewdog 🐶}
line is 121 characters (lll)

github-actions · 2021-02-24T09:02:21Z

pkg/meta/cassandra/handler/grpc/handler.go

 		case errors.IsErrCassandraUnavailable(err):
 			log.Warnf("[DeleteMetasInverse]\tunavailable\t%+v", err)
+			err = status.WrapWithUnavailable(fmt.Sprintf("DeleteMetasInverse API: Cassandra unavailable: vals %#v", vals.GetVals()), err,


🚫 [golangci] _{reported by reviewdog 🐶}
line is 128 characters (lll)

github-actions · 2021-02-24T09:46:54Z

pkg/meta/cassandra/handler/grpc/handler.go

 		case errors.IsErrCassandraUnavailable(err):
 			log.Warnf("[GetMetasInverse]\tunavailable\t%+v", err)
+			err = status.WrapWithUnavailable(fmt.Sprintf("GetMetasInverse API: Cassandra unavailable: vals %#v", vals.GetVals()), err,


🚫 [golangci] _{reported by reviewdog 🐶}
line is 125 characters (lll)

github-actions · 2021-02-24T09:46:54Z

pkg/meta/cassandra/handler/grpc/handler.go

 		default:
 			log.Errorf("[DeleteMetasInverse]\tunknown error\t%+v", err)
+			err = status.WrapWithUnknown(fmt.Sprintf("DeleteMetasInverse API: unknown error occurred: vals %#v", vals.GetVals()), err,


🚫 [golangci] _{reported by reviewdog 🐶}
line is 125 characters (lll)

github-actions · 2021-02-24T09:46:54Z

pkg/meta/cassandra/handler/grpc/handler.go

@@ -56,24 +57,55 @@ func (s *server) GetMeta(ctx context.Context, key *payload.Meta_Key) (*payload.M
 		switch {
 		case errors.IsErrCassandraNotFound(err):
 			log.Warnf("[GetMeta]\tnot found\t%v\t%s", key.GetKey(), err.Error())
+			err = status.WrapWithNotFound(fmt.Sprintf("GetMeta API: not found: key %s", key.GetKey()), err,
+				&errdetails.RequestInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in RequestInfo (exhaustivestruct)

github-actions · 2021-02-24T09:46:54Z

pkg/meta/cassandra/handler/grpc/handler.go

+					RequestId:   key.GetKey(),
+					ServingData: errdetails.Serialize(key),
+				},
+				&errdetails.ResourceInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
ResourceName, XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in ResourceInfo (exhaustivestruct)

github-actions · 2021-02-24T09:46:54Z

pkg/meta/cassandra/handler/grpc/handler.go

 		case errors.IsErrCassandraUnavailable(err):
 			log.Warnf("[GetMeta]\tunavailable\t%+v", err)
+			err = status.WrapWithUnavailable(fmt.Sprintf("GetMeta API: Cassandra unavailable: key %s", key.GetKey()), err,
+				&errdetails.RequestInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in RequestInfo (exhaustivestruct)

github-actions · 2021-02-24T09:46:55Z

pkg/meta/cassandra/handler/grpc/handler.go

+					RequestId:   key.GetKey(),
+					ServingData: errdetails.Serialize(key),
+				},
+				&errdetails.ResourceInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
ResourceName, XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in ResourceInfo (exhaustivestruct)

github-actions · 2021-02-24T09:46:55Z

pkg/meta/cassandra/handler/grpc/handler.go

@@ -94,24 +126,56 @@ func (s *server) GetMetas(ctx context.Context, keys *payload.Meta_Keys) (mv *pay
 		switch {
 		case errors.IsErrCassandraNotFound(err):
 			log.Warnf("[GetMetas]\tnot found\t%v\t%s", keys.GetKeys(), err.Error())
+			err = status.WrapWithNotFound(fmt.Sprintf("GetMetas API: not found: keys %#v", keys.GetKeys()), err,
+				&errdetails.RequestInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
RequestId, XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in RequestInfo (exhaustivestruct)

github-actions · 2021-02-24T09:46:55Z

pkg/meta/cassandra/handler/grpc/handler.go

 		case errors.IsErrCassandraUnavailable(err):
 			log.Warnf("[GetMetas]\tunavailable\t%+v", err)
+			err = status.WrapWithUnavailable(fmt.Sprintf("GetMetas API: Cassandra unavailable: keys %#v", keys.GetKeys()), err,
+				&errdetails.RequestInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
RequestId, XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in RequestInfo (exhaustivestruct)

github-actions · 2021-02-24T09:46:55Z

pkg/meta/cassandra/handler/grpc/handler.go


 		default:
 			log.Errorf("[GetMetas]\tunknown error\t%+v", err)
+			err = status.WrapWithUnknown(fmt.Sprintf("GetMetas API: unknown error occurred: keys %#v", keys.GetKeys()), err,
+				&errdetails.RequestInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
RequestId, XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in RequestInfo (exhaustivestruct)

github-actions · 2021-02-24T09:46:55Z

pkg/meta/cassandra/handler/grpc/handler.go

 		case errors.IsErrCassandraUnavailable(err):
 			log.Warnf("[DeleteMetaInverse]\tunavailable\t%+v", err)
+			err = status.WrapWithUnavailable(fmt.Sprintf("DeleteMetaInverse API: Cassandra unavailable:", val.GetVal()), err,


🚫 [golangci] _{reported by reviewdog 🐶}
printf: Sprintf call has arguments but no formatting directives (govet)

github-actions · 2021-02-25T02:32:17Z

pkg/meta/cassandra/handler/grpc/handler.go

@@ -56,24 +57,43 @@ func (s *server) GetMeta(ctx context.Context, key *payload.Meta_Key) (*payload.M
 		switch {
 		case errors.IsErrCassandraNotFound(err):
 			log.Warnf("[GetMeta]\tnot found\t%v\t%s", key.GetKey(), err.Error())
+			err = status.WrapWithNotFound(fmt.Sprintf("GetMeta API: not found: key %s", key.GetKey()), err,
+				&errdetails.ResourceInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in ResourceInfo (exhaustivestruct)

github-actions · 2021-02-25T02:32:17Z

pkg/meta/cassandra/handler/grpc/handler.go

 		case errors.IsErrCassandraUnavailable(err):
 			log.Warnf("[GetMeta]\tunavailable\t%+v", err)
+			err = status.WrapWithUnavailable(fmt.Sprintf("GetMeta API: Cassandra unavailable: key %s", key.GetKey()), err,
+				&errdetails.ResourceInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in ResourceInfo (exhaustivestruct)

github-actions · 2021-02-25T02:32:17Z

pkg/meta/cassandra/handler/grpc/handler.go

 		default:
 			log.Errorf("[GetMeta]\tunknown error\t%+v", err)
+			err = status.WrapWithUnknown(fmt.Sprintf("GetMeta API: unknown error occurred: key %s", key.GetKey()), err,
+				&errdetails.ResourceInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in ResourceInfo (exhaustivestruct)

github-actions · 2021-03-01T06:07:05Z

pkg/meta/redis/handler/grpc/handler.go

@@ -160,10 +216,17 @@ func (s *server) SetMeta(ctx context.Context, kv *payload.Meta_KeyVal) (_ *paylo
 	err = s.redis.Set(ctx, kv.GetKey(), kv.GetVal())
 	if err != nil {
 		log.Errorf("[SetMeta]\tunknown error\t%+v", err)
+		err = status.WrapWithInternal(fmt.Sprintf("SetMeta API: failed to store: key %s val %s", kv.GetKey(), kv.GetVal()), err,


🚫 [golangci] _{reported by reviewdog 🐶}
line is 122 characters (lll)

github-actions · 2021-03-01T06:07:05Z

pkg/meta/redis/handler/grpc/handler.go

 		}
 		log.Errorf("[DeleteMetasInverse]\tunknown error\t%+v", err)
+		err = status.WrapWithUnknown(fmt.Sprintf("DeleteMetasInverse API: unknown error occurred: vals %#v", vals.GetVals()), err,


🚫 [golangci] _{reported by reviewdog 🐶}
line is 124 characters (lll)

github-actions · 2021-03-01T06:07:05Z

pkg/meta/redis/handler/grpc/handler.go

@@ -55,16 +56,30 @@ func (s *server) GetMeta(ctx context.Context, key *payload.Meta_Key) (*payload.M
 	if err != nil {
 		if errors.IsErrRedisNotFound(err) {
 			log.Warnf("[GetMeta]\tnot found\t%v\t%s", key.GetKey(), err.Error())
+			err = status.WrapWithNotFound(fmt.Sprintf("GetMeta API: not found: key %s", key.GetKey()), err,
+				&errdetails.ResourceInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in ResourceInfo (exhaustivestruct)

github-actions · 2021-03-01T06:07:05Z

pkg/meta/redis/handler/grpc/handler.go

 		}
 		log.Errorf("[GetMeta]\tunknown error\t%+v", err)
+		err = status.WrapWithUnknown(fmt.Sprintf("GetMeta API: unknown error occurred: key %s", key.GetKey()), err,
+			&errdetails.ResourceInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in ResourceInfo (exhaustivestruct)

github-actions · 2021-03-01T06:07:05Z

pkg/meta/redis/handler/grpc/handler.go

@@ -83,16 +98,30 @@ func (s *server) GetMetas(ctx context.Context, keys *payload.Meta_Keys) (mv *pay
 	if err != nil {
 		if errors.IsErrRedisNotFound(err) {
 			log.Warnf("[GetMetas]\tnot found\t%v\t%s", keys.GetKeys(), err.Error())
+			err = status.WrapWithNotFound(fmt.Sprintf("GetMetas API: not found: keys %#v", keys.GetKeys()), err,
+				&errdetails.ResourceInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in ResourceInfo (exhaustivestruct)

github-actions · 2021-03-01T06:07:05Z

pkg/meta/redis/handler/grpc/handler.go

@@ -108,16 +137,29 @@ func (s *server) GetMetaInverse(ctx context.Context, val *payload.Meta_Val) (*pa
 	if err != nil {
 		if errors.IsErrRedisNotFound(err) {
 			log.Warnf("[GetMetaInverse]\tnot found\t%v\t%s", val.GetVal(), err.Error())
+			err = status.WrapWithNotFound(fmt.Sprintf("GetMetaInverse API: not found: val %s", val.GetVal()), err,
+				&errdetails.ResourceInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
ResourceName, XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in ResourceInfo (exhaustivestruct)

kpango · 2021-03-02T10:52:08Z

In the case of Unavailale or Unkonwn errors, it would be better to return the target IP of the failed connection as the resource name in errdetails.ResourceInfo and additionally errdetails.RequestInfo containing the key of the request.

rinx · 2021-03-03T01:19:50Z

Agree. I'll revise it.

rinx · 2021-03-03T02:40:58Z

Both of gocql and go-redis don't provide informations about requesting Cassandra/Redis hosts. So we cannot embed IPs of these hosts into ResourceInfo.

rinx · 2021-03-03T02:52:03Z

I've just noticed that some of the Cassandra errors can be categorized as the gRPC errors other than the Unknown error. So I'll tackle with it.

rinx · 2021-03-03T07:19:44Z

Now ready to be reviewed.
/rebase

vdaas-ci · 2021-03-03T07:20:21Z

[REBASE] Rebase triggered by rinx for branch: refactor/metas/revise-grpc-status-codes-in-error-cases

kpango

Others looks good to me

pkg/meta/cassandra/handler/grpc/handler.go

rinx · 2021-03-03T09:03:44Z

Updated.
/rebase

vdaas-ci · 2021-03-03T09:04:24Z

[REBASE] Rebase triggered by rinx for branch: refactor/metas/revise-grpc-status-codes-in-error-cases

github-actions · 2021-03-03T09:10:50Z

pkg/meta/redis/handler/grpc/handler.go

 		}
 		log.Errorf("[GetMetasInverse]\tunknown error\t%+v", err)
+		err = status.WrapWithUnknown(fmt.Sprintf("GetMetasInverse API: unknown error occurred: vals %#v", vals.GetVals()), err,


🚫 [golangci] _{reported by reviewdog 🐶}
line is 121 characters (lll)

github-actions · 2021-03-03T09:10:50Z

pkg/meta/redis/handler/grpc/handler.go

@@ -55,16 +56,34 @@ func (s *server) GetMeta(ctx context.Context, key *payload.Meta_Key) (*payload.M
 	if err != nil {
 		if errors.IsErrRedisNotFound(err) {
 			log.Warnf("[GetMeta]\tnot found\t%v\t%s", key.GetKey(), err.Error())
+			err = status.WrapWithNotFound(fmt.Sprintf("GetMeta API: not found: key %s", key.GetKey()), err,
+				&errdetails.RequestInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
RequestId, XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in RequestInfo (exhaustivestruct)

github-actions · 2021-03-03T09:10:50Z

pkg/meta/redis/handler/grpc/handler.go

+				&errdetails.RequestInfo{
+					ServingData: errdetails.Serialize(key),
+				},
+				&errdetails.ResourceInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
ResourceName, XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in ResourceInfo (exhaustivestruct)

github-actions · 2021-03-03T09:10:51Z

pkg/meta/redis/handler/grpc/handler.go

 		}
 		log.Errorf("[GetMeta]\tunknown error\t%+v", err)
+		err = status.WrapWithUnknown(fmt.Sprintf("GetMeta API: unknown error occurred: key %s", key.GetKey()), err,
+			&errdetails.RequestInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
RequestId, XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in RequestInfo (exhaustivestruct)

github-actions · 2021-03-03T09:10:51Z

pkg/meta/redis/handler/grpc/handler.go

+			&errdetails.RequestInfo{
+				ServingData: errdetails.Serialize(key),
+			},
+			&errdetails.ResourceInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
ResourceName, XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in ResourceInfo (exhaustivestruct)

github-actions · 2021-03-03T09:10:51Z

pkg/meta/redis/handler/grpc/handler.go

@@ -83,16 +102,34 @@ func (s *server) GetMetas(ctx context.Context, keys *payload.Meta_Keys) (mv *pay
 	if err != nil {
 		if errors.IsErrRedisNotFound(err) {
 			log.Warnf("[GetMetas]\tnot found\t%v\t%s", keys.GetKeys(), err.Error())
+			err = status.WrapWithNotFound(fmt.Sprintf("GetMetas API: not found: keys %#v", keys.GetKeys()), err,
+				&errdetails.RequestInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
RequestId, XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in RequestInfo (exhaustivestruct)

github-actions · 2021-03-03T09:10:51Z

pkg/meta/redis/handler/grpc/handler.go

+				&errdetails.RequestInfo{
+					ServingData: errdetails.Serialize(keys),
+				},
+				&errdetails.ResourceInfo{


🚫 [golangci] _{reported by reviewdog 🐶}
ResourceName, XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in ResourceInfo (exhaustivestruct)

rinx · 2021-03-08T08:45:39Z

/rebase

vdaas-ci · 2021-03-08T08:46:22Z

[REBASE] Rebase triggered by rinx for branch: refactor/metas/revise-grpc-status-codes-in-error-cases

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

kpango

LGTM

…-error-cases

github-actions bot added area/meta size/L type/refactoring priority/low labels Feb 17, 2021

rinx added status/in-progress and removed priority/low labels Feb 17, 2021

github-actions bot reviewed Feb 17, 2021

View reviewed changes

rinx force-pushed the refactor/metas/revise-grpc-status-codes-in-error-cases branch from 2bf54a4 to f341215 Compare February 24, 2021 08:53

github-actions bot added size/XL priority/low and removed size/L labels Feb 24, 2021

github-actions bot reviewed Feb 24, 2021

View reviewed changes

github-actions bot added size/L and removed size/L labels Feb 25, 2021

github-actions bot reviewed Feb 25, 2021

View reviewed changes

rinx force-pushed the refactor/metas/revise-grpc-status-codes-in-error-cases branch from 4b4b0d9 to c8687d1 Compare March 1, 2021 05:19

github-actions bot added size/L and removed size/L labels Mar 1, 2021

github-actions bot reviewed Mar 1, 2021

View reviewed changes

rinx marked this pull request as ready for review March 1, 2021 06:09

kpango self-requested a review March 2, 2021 05:06

rinx marked this pull request as draft March 3, 2021 02:53

rinx marked this pull request as ready for review March 3, 2021 07:19

vdaas-ci force-pushed the refactor/metas/revise-grpc-status-codes-in-error-cases branch from 112ef2c to 57bd288 Compare March 3, 2021 07:20

kpango requested changes Mar 3, 2021

View reviewed changes

vdaas-ci force-pushed the refactor/metas/revise-grpc-status-codes-in-error-cases branch from 029b008 to 842ee91 Compare March 3, 2021 09:04

github-actions bot reviewed Mar 3, 2021

View reviewed changes

rinx added 8 commits March 8, 2021 08:46

♻️ Revise meta-redis gRPC error statuses and details

defc37e

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

♻️ Revise meta-cassandra gRPC error statuses and details

9bff8d7

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🔧 Add info.Get to error details

b06730f

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🔧 Fill resourceName and remove RequestInfo

41eb288

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🐛 Fix sprintf

a7bf39e

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

♻️ Embedding request payload into RequestInfo

5324c88

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🎨 Use Internal and FailedPrecondition statuses for Cassandra errors

c05b92b

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🎨 Use WrapWithFailedPrecondition for precondition failures

ea6287b

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

vdaas-ci force-pushed the refactor/metas/revise-grpc-status-codes-in-error-cases branch from 842ee91 to ea6287b Compare March 8, 2021 08:46

rinx requested a review from kpango March 8, 2021 08:50

kpango approved these changes Mar 16, 2021

View reviewed changes

Merge branch 'master' into refactor/metas/revise-grpc-status-codes-in…

005a064

…-error-cases

kpango merged commit e24d71a into master Mar 16, 2021

kpango deleted the refactor/metas/revise-grpc-status-codes-in-error-cases branch March 16, 2021 03:41

vdaas-ci mentioned this pull request Mar 17, 2021

[patch] Release v1.0.4 #1087

Merged

Revise gRPC error statuses and details in meta (Redis/Cassandra) #1013

Revise gRPC error statuses and details in meta (Redis/Cassandra) #1013

Conversation

rinx commented Feb 17, 2021 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vdaas-ci commented Feb 17, 2021

codecov bot commented Feb 17, 2021 • edited Loading

Codecov Report

github-actions bot Feb 17, 2021

Choose a reason for hiding this comment

github-actions bot Feb 24, 2021

Choose a reason for hiding this comment

github-actions bot Feb 24, 2021

Choose a reason for hiding this comment

github-actions bot Feb 24, 2021

Choose a reason for hiding this comment

github-actions bot Feb 24, 2021

Choose a reason for hiding this comment

github-actions bot Feb 24, 2021

Choose a reason for hiding this comment

github-actions bot Feb 24, 2021

Choose a reason for hiding this comment

github-actions bot Feb 24, 2021

Choose a reason for hiding this comment

github-actions bot Feb 24, 2021

Choose a reason for hiding this comment

github-actions bot Feb 24, 2021

Choose a reason for hiding this comment

github-actions bot Feb 24, 2021

Choose a reason for hiding this comment

github-actions bot Feb 24, 2021

Choose a reason for hiding this comment

github-actions bot Feb 24, 2021

Choose a reason for hiding this comment

github-actions bot Feb 24, 2021

Choose a reason for hiding this comment

github-actions bot Feb 24, 2021

Choose a reason for hiding this comment

github-actions bot Feb 25, 2021

Choose a reason for hiding this comment

github-actions bot Feb 25, 2021

Choose a reason for hiding this comment

github-actions bot Feb 25, 2021

Choose a reason for hiding this comment

github-actions bot Mar 1, 2021

Choose a reason for hiding this comment

github-actions bot Mar 1, 2021

Choose a reason for hiding this comment

github-actions bot Mar 1, 2021

Choose a reason for hiding this comment

github-actions bot Mar 1, 2021

Choose a reason for hiding this comment

github-actions bot Mar 1, 2021

Choose a reason for hiding this comment

github-actions bot Mar 1, 2021

Choose a reason for hiding this comment

kpango commented Mar 2, 2021

rinx commented Mar 3, 2021

rinx commented Mar 3, 2021

rinx commented Mar 3, 2021 • edited Loading

rinx commented Mar 3, 2021

vdaas-ci commented Mar 3, 2021

kpango left a comment

Choose a reason for hiding this comment

rinx commented Mar 3, 2021

vdaas-ci commented Mar 3, 2021

github-actions bot Mar 3, 2021

Choose a reason for hiding this comment

github-actions bot Mar 3, 2021

Choose a reason for hiding this comment

github-actions bot Mar 3, 2021

Choose a reason for hiding this comment

github-actions bot Mar 3, 2021

Choose a reason for hiding this comment

rinx commented Feb 17, 2021 •

edited

Loading

codecov bot commented Feb 17, 2021 •

edited

Loading

rinx commented Mar 3, 2021 •

edited

Loading