Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling of SearchByID API in lb gateway #1084

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Mar 16, 2021

Description:

  • I've just found a typo in the code. -> fixed
  • also, I've found an ambiguous function name in internal/db -> renamed.

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

  • Go Version: 1.16
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@rinx
Copy link
Contributor Author

rinx commented Mar 16, 2021

/rebase
/format

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by rinx for branch: bugfix/gateways/fix-error-handling-codes

@vdaas-ci vdaas-ci force-pushed the bugfix/gateways/fix-error-handling-codes branch from 7ac0e1d to 3217dd4 Compare March 16, 2021 06:19
@rinx rinx mentioned this pull request Mar 16, 2021
18 tasks
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by rinx.

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #1084 (769061e) into master (0beb8ae) will decrease coverage by 1.07%.
The diff coverage is 1.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1084      +/-   ##
==========================================
- Coverage   15.25%   14.17%   -1.08%     
==========================================
  Files         498      495       -3     
  Lines       28770    29190     +420     
==========================================
- Hits         4389     4139     -250     
- Misses      24110    24796     +686     
+ Partials      271      255      -16     
Impacted Files Coverage Δ
pkg/gateway/lb/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/meta/cassandra/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/meta/redis/handler/grpc/handler.go 0.00% <0.00%> (ø)
internal/db/rdb/mysql/mysql.go 94.46% <100.00%> (ø)
internal/worker/worker.go 82.29% <0.00%> (-2.09%) ⬇️
internal/worker/queue.go 98.33% <0.00%> (-1.67%) ⬇️
internal/net/dialer.go
internal/net/net.go
internal/net/option.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 851e6d6...3217dd4. Read the comment docs.

@kpango
Copy link
Collaborator

kpango commented Mar 16, 2021

I thought @vankichi wrote internal/db logging function, so could you please review this PR?

Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks!

@kpango kpango merged commit e0b8627 into master Mar 16, 2021
@kpango kpango deleted the bugfix/gateways/fix-error-handling-codes branch March 16, 2021 06:49
@vdaas-ci vdaas-ci mentioned this pull request Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants