-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error handling of SearchByID API in lb gateway #1084
Conversation
/rebase |
[CHATOPS:HELP] ChatOps commands.
|
[REBASE] Rebase triggered by rinx for branch: bugfix/gateways/fix-error-handling-codes |
7ac0e1d
to
3217dd4
Compare
[FORMAT] Updating license headers and formatting go codes triggered by rinx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #1084 +/- ##
==========================================
- Coverage 15.25% 14.17% -1.08%
==========================================
Files 498 495 -3
Lines 28770 29190 +420
==========================================
- Hits 4389 4139 -250
- Misses 24110 24796 +686
+ Partials 271 255 -16
Continue to review full report at Codecov.
|
I thought @vankichi wrote internal/db logging function, so could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks!
Description:
Related Issue:
nothing
How Has This Been Tested?:
nothing
Environment:
Types of changes:
Changes to Core Features:
Checklist: