Improve internal package tests

[kevindiu]

Description:

This PR include the following changes:

• using NOP logger for test
• wrap goleak library to internal package, default ignore conflict with parallel test
• update goleak import path
• Update exist tests to add prefix to the environment name
• fix internal/db/storage/blob/s3/reader/reader_test.go error
• fix internal/file/file_test.go goleak error
• close watcher after test in internal/file/watch/watch_test.go

The PR seems huge but most of them are updating NOP logger for test, and update the goleak import path.

Since goleak doesn't support parallel test, this PR does not update to support parallel test.
ref: uber-go/goleak#16

Related Issue:

How Has This Been Tested?:

Environment:

• Go Version: 1.16
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.12.3

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - replace the PR body by changelog details
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase master
• 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

[codecov]

Codecov Report

Merging #1227 (b700761) into master (b898fd9) will increase coverage by 0.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
+ Coverage   17.36%   17.89%   +0.52%     
==========================================
  Files         509      512       +3     
  Lines       32259    32614     +355     
==========================================
+ Hits         5601     5835     +234     
- Misses      26352    26457     +105     
- Partials      306      322      +16     

Impacted Files	Coverage Δ
internal/db/storage/blob/s3/reader/reader.go	63.33% <0.00%> (-31.12%)	⬇️
internal/net/net.go	49.18% <0.00%> (ø)
internal/net/dialer.go	79.42% <0.00%> (ø)
internal/net/option.go	89.65% <0.00%> (ø)
internal/worker/worker.go	83.33% <0.00%> (+2.08%)	⬆️
internal/file/watch/watch.go	92.92% <0.00%> (+3.03%)	⬆️
internal/config/discoverer.go	83.33% <0.00%> (+33.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b898fd9...b700761. Read the comment docs.

[kevindiu]

/rebase
/format

[vdaas-ci]

[REBASE] Rebase triggered by kevindiu for branch: test/internal/fix-test-error

[vdaas-ci]

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

[kevindiu]

/format

[vdaas-ci]

[REBASE] Rebase triggered by kevindiu for branch: test/internal/fix-test-error

[kpango]

it would be better to update header.tmpl to change import path for goleak

[kevindiu]

/rebase

[vdaas-ci]

[REBASE] Rebase triggered by kevindiu for branch: test/internal/fix-test-error

[kevindiu]

/rebase

[vdaas-ci]

[REBASE] Rebase triggered by kevindiu for branch: test/internal/fix-test-error

[kevindiu]

Since goleak does not support parallel test to use defer goleak.VerifyNone(), it only support checking it through TestMain(). S
Should we implement the following function in each package to enable parallel test

func TestMain(m *testing.M) {
	goleak.VerifyTestMain(m)
}

or should we disable parallel test and use defer goleak.VerifyNone()?

[kpango]

LGTM