Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add single connection client for agent & vald #1254

Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented May 25, 2021

Signed-off-by: kpango kpango@vdaas.org

Description:

add single connection client for agent & vald

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.16.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango requested review from kevindiu and hlts2 May 25, 2021 02:19
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

internal/client/v1/client/agent/core/client.go Outdated Show resolved Hide resolved
internal/client/v1/client/vald/vald.go Outdated Show resolved Hide resolved
internal/client/v1/client/vald/vald.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #1254 (e8cea2e) into master (4e4367c) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
- Coverage   18.08%   17.89%   -0.19%     
==========================================
  Files         501      501              
  Lines       31303    31465     +162     
==========================================
- Hits         5660     5631      -29     
- Misses      25349    25535     +186     
- Partials      294      299       +5     
Impacted Files Coverage Δ
internal/client/v1/client/agent/core/client.go 0.00% <0.00%> (ø)
internal/client/v1/client/vald/vald.go 0.00% <0.00%> (ø)
internal/net/grpc/client.go 0.00% <0.00%> (ø)
internal/db/storage/blob/s3/reader/reader.go 63.73% <0.00%> (-30.77%) ⬇️
internal/worker/queue.go 95.00% <0.00%> (-5.00%) ⬇️
internal/backoff/backoff.go 87.69% <0.00%> (+3.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e4367c...e8cea2e. Read the comment docs.

Signed-off-by: kpango <kpango@vdaas.org>
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
LGTM

Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango
Copy link
Collaborator Author

kpango commented May 25, 2021

@kevindiu @hlts2 Thanks for the review.
I will merge this PR after E2E tests have been completed excluding Redis&MySQL E2E.

@kpango kpango merged commit 5a66d20 into master May 25, 2021
@kpango kpango deleted the feature/internal-client/add-simple-grpc-connection-agent-client branch May 25, 2021 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants