Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] change exists cheking for agent vqueue #1256

Merged
merged 3 commits into from
May 25, 2021

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented May 25, 2021

Signed-off-by: kpango kpango@vdaas.org

Description:

[bugfix] change exists cheking for agent vqueue

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.16.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: kpango <kpango@vdaas.org>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #1256 (0c02c0f) into master (86b1269) will decrease coverage by 0.60%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1256      +/-   ##
==========================================
- Coverage   18.05%   17.44%   -0.61%     
==========================================
  Files         501      498       -3     
  Lines       31483    31139     -344     
==========================================
- Hits         5683     5432     -251     
+ Misses      25507    25430      -77     
+ Partials      293      277      -16     
Impacted Files Coverage Δ
internal/net/grpc/client.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/service/ngt.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/service/vqueue/queue.go 0.00% <0.00%> (ø)
internal/backoff/backoff.go 84.61% <0.00%> (-3.08%) ⬇️
internal/net/option.go
internal/net/net.go
internal/net/dialer.go
internal/worker/worker.go 83.33% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b1269...0c02c0f. Read the comment docs.

kevindiu
kevindiu previously approved these changes May 25, 2021
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hlts2
hlts2 previously approved these changes May 25, 2021
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango dismissed stale reviews from hlts2 and kevindiu via 0c02c0f May 25, 2021 09:44
@github-actions github-actions bot added size/M and removed size/S labels May 25, 2021
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit ffcf4ab into master May 25, 2021
@kpango kpango deleted the bugfix/agent-vqueue/change-existing-checking branch May 25, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants