Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement pkg handler exists test cases #1628

Merged
merged 4 commits into from
May 9, 2022
Merged

implement pkg handler exists test cases #1628

merged 4 commits into from
May 9, 2022

Conversation

kmrmt
Copy link
Contributor

@kmrmt kmrmt commented Apr 20, 2022

Signed-off-by: Kosuke Morimoto ksk@vdaas.org

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.1
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@kmrmt kmrmt requested a review from vankichi April 20, 2022 05:00
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kmrmt kmrmt requested a review from kevindiu April 20, 2022 05:00
@codecov
Copy link

codecov bot commented Apr 20, 2022 •
edited
Loading

Codecov Report

Merging #1628 (c372b27) into master (cc067a3) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1628      +/-   ##
==========================================
+ Coverage   30.61%   30.70%   +0.08%     
==========================================
  Files         372      372              
  Lines       32234    32234              
==========================================
+ Hits         9869     9896      +27     
+ Misses      21998    21972      -26     
+ Partials      367      366       -1
Impacted Files Coverage Δ
internal/errgroup/group.go 93.00% <0.00%> (-2.00%) ⬇️
internal/worker/worker.go 83.59% <0.00%> (-0.79%) ⬇️
...nt/core/ngt/service/vqueue/uninserted_index_map.go 73.22% <0.00%> (+0.54%) ⬆️
internal/core/algorithm/ngt/ngt.go 65.35% <0.00%> (+0.65%) ⬆️
pkg/agent/core/ngt/handler/grpc/handler.go 10.68% <0.00%> (+1.05%) ⬆️
...ent/core/ngt/service/vqueue/undeleted_index_map.go 71.11% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499e2f0...c372b27. Read the comment docs.

@kmrmt
Copy link
Contributor Author

kmrmt commented Apr 20, 2022

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kmrmt for branch: test/pkg/implement-agent-ngt-handler-exists-test

@vdaas-ci
Copy link
Collaborator

[REBASE] Failed to rebase.

@kmrmt kmrmt force-pushed the test/pkg/implement-agent-ngt-handler-exists-test branch from ce2d137 to 09deddd Compare April 20, 2022 05:29
@vankichi
Copy link
Contributor

It's fine about the test case.

@kmrmt kmrmt force-pushed the test/pkg/implement-agent-ngt-handler-exists-test branch from 5894fad to dc0ace3 Compare April 22, 2022 02:30
kmrmt and others added 3 commits April 28, 2022 19:57
@kmrmt
add drafts of exists test cases
74cb87a 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt @kevindiu
Update pkg/agent/core/ngt/handler/grpc/handler_test.go
76ce089 
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
@kmrmt
add pkg agent ngt handler exists test cases
6d5a166 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt kmrmt marked this pull request as ready for review April 28, 2022 11:07
@kmrmt kmrmt changed the title [WIP] add drafts of exists test cases implement pkg handler exists test cases Apr 28, 2022
@kmrmt kmrmt force-pushed the test/pkg/implement-agent-ngt-handler-exists-test branch from e38a3b4 to 6d5a166 Compare May 9, 2022 01:24
@github-actions github-actions bot added size/L and removed size/S labels May 9, 2022
kevindiu
kevindiu previously approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vankichi
vankichi reviewed May 9, 2022
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix some missed spells?
Almost LGTM!

@kmrmt
fix missspellings
c372b27 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented May 9, 2022

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

kevindiu
kevindiu approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmrmt kmrmt merged commit 87679e9 into master May 9, 2022
@kmrmt kmrmt deleted the test/pkg/implement-agent-ngt-handler-exists-test branch May 9, 2022 06:07
This was referenced May 24, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@vankichi vankichi vankichi approved these changes

@kevindiu kevindiu kevindiu approved these changes

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-profiling area/agent/core priority/low size/L team/set SET team type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmrmt @vdaas-ci @vankichi @kevindiu