implement pkg handler remove test cases

[kmrmt]

Signed-off-by: Kosuke Morimoto ksk@vdaas.org

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

• Go Version: 1.18.1
• Docker Version: 20.10.8
• Kubernetes Version: 1.22.0
• NGT Version: 1.14.3

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - replace the PR body by changelog details
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase master
• 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

[codecov]

Codecov Report

Merging #1644 (a7bf98d) into master (13c62b1) will increase coverage by 0.10%.
The diff coverage is 43.29%.

@@            Coverage Diff             @@
##           master    #1644      +/-   ##
==========================================
+ Coverage   30.70%   30.81%   +0.10%     
==========================================
  Files         372      372              
  Lines       32234    32395     +161     
==========================================
+ Hits         9897     9981      +84     
- Misses      21970    22040      +70     
- Partials      367      374       +7     

Impacted Files	Coverage Δ
pkg/agent/core/ngt/handler/grpc/handler.go	14.04% <42.23%> (+3.36%)	⬆️
internal/errors/ngt.go	89.65% <100.00%> (+0.56%)	⬆️
...nt/core/ngt/service/vqueue/uninserted_index_map.go	70.49% <0.00%> (-5.47%)	⬇️
internal/backoff/backoff.go	85.54% <0.00%> (-2.41%)	⬇️
internal/worker/worker.go	84.37% <0.00%> (+0.78%)	⬆️
internal/worker/queue.go	100.00% <0.00%> (+1.26%)	⬆️
internal/errgroup/group.go	95.00% <0.00%> (+2.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d6a6c4...a7bf98d. Read the comment docs.

[vankichi]

@kmrmt
the case is fine :)
please keep continuing implementation!

[vankichi]

Suggested change

	indexId string
	removeId string
	originId string
	indexedId string

or

Suggested change

	indexId string
	removeId string
	indexId string
	targetId string

umm... 🤔
Of course, I do not care if you won't change.

[kmrmt]

My intent is that indexId means the id which is in the Vald and removeId means the id which is request for remove.
It is too difficult so let me put it in current expression for once.

[kevindiu]

I think this changes needs to pass E2E, what do you think?

[vdaas-ci]

Profile Report

type	vald-agent-ngt	vald-lb-gateway	vald-discoverer	vald-manager-index
cpu
heap

other images

[vankichi]

@kpango CRE review has passed. Please review.

[kpango]

LGTM