Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go tool installation #1649

Merged
merged 8 commits into from
May 16, 2022
Merged

Conversation

kmrmt
Copy link
Contributor

@kmrmt kmrmt commented May 11, 2022

Signed-off-by: Kosuke Morimoto ksk@vdaas.org

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.1
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt kmrmt requested review from kpango, hlts2 and datelier May 11, 2022 09:52
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Makefile.d/test.mk Outdated Show resolved Hide resolved
Makefile.d/test.mk Outdated Show resolved Hide resolved
@kpango
Copy link
Collaborator

kpango commented May 12, 2022

after suggestion commit.
could you please replace the Makefile function (go-get) name to go-install?

kmrmt and others added 5 commits May 13, 2022 11:28
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
hlts2
hlts2 previously approved these changes May 13, 2022
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 6d6a6c4 into master May 16, 2022
@kpango kpango deleted the bugfix/makefile/fix-go-tool-installation branch May 16, 2022 02:21
This was referenced May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants