-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test for maxDimensionTest #1650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
team/set
SET team
size/L
type/test
Adding tests
priority/low
labels
May 12, 2022
vankichi
changed the title
implement e2e for maxDimensionTest
[WIP] implement e2e for maxDimensionTest
May 12, 2022
vankichi
force-pushed
the
test/e2e/add-max-dimension-e2e-test
branch
from
May 12, 2022 07:30
56ad8c2
to
0eb0f8e
Compare
vankichi
force-pushed
the
test/e2e/add-max-dimension-e2e-test
branch
from
May 16, 2022 07:29
7cad460
to
3942380
Compare
vankichi
changed the title
[WIP] implement e2e for maxDimensionTest
implement e2e for maxDimensionTest
May 16, 2022
vankichi
changed the title
implement e2e for maxDimensionTest
Add e2e test for maxDimensionTest
May 17, 2022
vankichi
changed the title
Add e2e test for maxDimensionTest
[WIP] Add e2e test for maxDimensionTest
May 17, 2022
vankichi
changed the title
[WIP] Add e2e test for maxDimensionTest
Add e2e test for maxDimensionTest
May 18, 2022
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
vankichi
force-pushed
the
test/e2e/add-max-dimension-e2e-test
branch
from
May 23, 2022 08:52
c6bb079
to
3a35ab8
Compare
Signed-off-by: vankichi <kyukawa315@gmail.com>
vankichi
force-pushed
the
test/e2e/add-max-dimension-e2e-test
branch
from
May 23, 2022 15:25
e7cc1ef
to
f2b6c9a
Compare
Signed-off-by: vankichi <kyukawa315@gmail.com>
vankichi
force-pushed
the
test/e2e/add-max-dimension-e2e-test
branch
from
May 23, 2022 15:26
f2b6c9a
to
ed3307e
Compare
Signed-off-by: vankichi <kyukawa315@gmail.com>
Profile Report
|
kmrmt
previously approved these changes
May 24, 2022
kpango
previously approved these changes
May 24, 2022
hlts2
reviewed
May 24, 2022
hlts2
previously approved these changes
May 24, 2022
hlts2
approved these changes
May 24, 2022
kevindiu
approved these changes
May 24, 2022
kpango
approved these changes
May 24, 2022
This was referenced May 24, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
actions/e2e-chaos
actions/e2e-deploy
actions/e2e-profiling
area/internal
priority/low
size/L
team/set
SET team
team/sre
SRE team
type/ci
type/test
Adding tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vankichi kyukawa315@gmail.com
Description:
I have implemented the new e2e test for maxVectorDimension.
Now, this test runs by attaching label,
actions/e2e-max-dim
.The testing process is similar to #1633
The example test results are here
Related Issue:
How Has This Been Tested?:
https://github.com/vankichi/vald/runs/6565584037?check_suite_focus=true
Environment:
Types of changes:
Changes to Core Features:
Checklist: