Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for maxDimensionTest #1650

Merged
merged 31 commits into from
May 24, 2022
Merged

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented May 12, 2022

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

I have implemented the new e2e test for maxVectorDimension.
Now, this test runs by attaching label, actions/e2e-max-dim.

The testing process is similar to #1633

The example test results are here

Related Issue:

How Has This Been Tested?:

https://github.com/vankichi/vald/runs/6565584037?check_suite_focus=true

Environment:

  • Go Version: 1.18.1
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango requested review from kevindiu and kmrmt May 12, 2022 04:34
@vankichi vankichi changed the title implement e2e for maxDimensionTest [WIP] implement e2e for maxDimensionTest May 12, 2022
@vankichi vankichi force-pushed the test/e2e/add-max-dimension-e2e-test branch from 56ad8c2 to 0eb0f8e Compare May 12, 2022 07:30
@vankichi vankichi force-pushed the test/e2e/add-max-dimension-e2e-test branch from 7cad460 to 3942380 Compare May 16, 2022 07:29
@vankichi vankichi changed the title [WIP] implement e2e for maxDimensionTest implement e2e for maxDimensionTest May 16, 2022
@vankichi vankichi marked this pull request as ready for review May 16, 2022 07:42
@vankichi vankichi changed the title implement e2e for maxDimensionTest Add e2e test for maxDimensionTest May 17, 2022
@vankichi vankichi changed the title Add e2e test for maxDimensionTest [WIP] Add e2e test for maxDimensionTest May 17, 2022
@vankichi vankichi changed the title [WIP] Add e2e test for maxDimensionTest Add e2e test for maxDimensionTest May 18, 2022
@vankichi vankichi requested a review from hlts2 May 18, 2022 07:00
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the test/e2e/add-max-dimension-e2e-test branch from c6bb079 to 3a35ab8 Compare May 23, 2022 08:52
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the test/e2e/add-max-dimension-e2e-test branch from e7cc1ef to f2b6c9a Compare May 23, 2022 15:25
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the test/e2e/add-max-dimension-e2e-test branch from f2b6c9a to ed3307e Compare May 23, 2022 15:26
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

kmrmt
kmrmt previously approved these changes May 24, 2022
kpango
kpango previously approved these changes May 24, 2022
hlts2
hlts2 previously approved these changes May 24, 2022
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi dismissed stale reviews from hlts2, kpango, and kmrmt via 7e01b5c May 24, 2022 05:31
@vankichi vankichi requested review from kmrmt and kpango May 24, 2022 05:33
@kpango kpango merged commit 8720310 into master May 24, 2022
@kpango kpango deleted the test/e2e/add-max-dimension-e2e-test branch May 24, 2022 05:35
This was referenced May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants