Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix update bug #1660

Merged

Conversation

kmrmt
Copy link
Contributor

@kmrmt kmrmt commented May 18, 2022

Signed-off-by: Kosuke Morimoto ksk@vdaas.org

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt kmrmt requested review from kpango, hlts2 and datelier May 18, 2022 05:49
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1660 (1c2d21f) into master (d55e2db) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1660      +/-   ##
==========================================
+ Coverage   30.80%   30.86%   +0.05%     
==========================================
  Files         372      372              
  Lines       32395    32395              
==========================================
+ Hits         9980     9998      +18     
+ Misses      22042    22027      -15     
+ Partials      373      370       -3     
Impacted Files Coverage Δ
pkg/agent/core/ngt/service/ngt.go 20.44% <100.00%> (ø)
internal/worker/worker.go 84.37% <0.00%> (+0.78%) ⬆️
internal/errgroup/group.go 95.00% <0.00%> (+1.00%) ⬆️
internal/worker/queue.go 100.00% <0.00%> (+1.26%) ⬆️
...ent/core/ngt/service/vqueue/undeleted_index_map.go 71.11% <0.00%> (+2.77%) ⬆️
...nt/core/ngt/service/vqueue/uninserted_index_map.go 78.68% <0.00%> (+5.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d55e2db...1c2d21f. Read the comment docs.

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge this PR after E2E test has been passed.

@kpango kpango merged commit 39c94df into master May 19, 2022
@kpango kpango deleted the bugfix/pkg/fix-agent-update-cannot-return-not-found-error branch May 19, 2022 01:30
This was referenced May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants