Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search config details document #1661

Merged
merged 9 commits into from
May 24, 2022

Conversation

vankichi
Copy link
Contributor

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vankichi vankichi requested review from kevindiu and kmrmt May 18, 2022 08:16
@kpango kpango changed the title create search config details document [WIP] create search config details document May 19, 2022
@vankichi vankichi force-pushed the documentation/docs/add-search-config-param-document branch from f82d3af to 31fd78f Compare May 20, 2022 08:39
@github-actions github-actions bot added size/L and removed size/S labels May 20, 2022
docs/user-guides/search-config.md Outdated Show resolved Hide resolved
docs/user-guides/search-config.md Outdated Show resolved Hide resolved
docs/user-guides/search-config.md Outdated Show resolved Hide resolved
docs/user-guides/search-config.md Outdated Show resolved Hide resolved
docs/user-guides/search-config.md Outdated Show resolved Hide resolved
docs/user-guides/search-config.md Show resolved Hide resolved
docs/user-guides/search-config.md Show resolved Hide resolved
docs/user-guides/search-config.md Show resolved Hide resolved
docs/user-guides/search-config.md Show resolved Hide resolved
docs/user-guides/search-config.md Outdated Show resolved Hide resolved
@vankichi vankichi force-pushed the documentation/docs/add-search-config-param-document branch 4 times, most recently from 7ac51f8 to e02f394 Compare May 20, 2022 08:48
@vankichi vankichi changed the title [WIP] create search config details document Add search config details document May 20, 2022
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the documentation/docs/add-search-config-param-document branch from 07d376b to 7e2ab6a Compare May 20, 2022 09:06
@vankichi vankichi marked this pull request as ready for review May 20, 2022 09:06
docs/user-guides/search-config.md Outdated Show resolved Hide resolved
docs/user-guides/search-config.md Show resolved Hide resolved
docs/user-guides/search-config.md Show resolved Hide resolved
docs/user-guides/search-config.md Show resolved Hide resolved
docs/user-guides/search-config.md Outdated Show resolved Hide resolved
docs/user-guides/search-config.md Outdated Show resolved Hide resolved
docs/user-guides/search-config.md Outdated Show resolved Hide resolved
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi requested a review from kmrmt May 24, 2022 02:24
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
@vankichi vankichi requested a review from kevindiu May 24, 2022 03:00
kmrmt
kmrmt previously approved these changes May 24, 2022
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
@vankichi vankichi requested review from kpango and kmrmt May 24, 2022 05:24
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
@vankichi vankichi merged commit 579d59e into master May 24, 2022
@vankichi vankichi deleted the documentation/docs/add-search-config-param-document branch May 24, 2022 06:22
This was referenced May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants