Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add invalid id argument handling #1667

Merged
merged 2 commits into from
May 23, 2022

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented May 23, 2022

Signed-off-by: kpango kpango@vdaas.org

Description:

add UUID checking logic for gateway
if required id is nil gateway returns InvalidArgument status code

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@kpango kpango marked this pull request as ready for review May 23, 2022 04:25
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Merge branch 'master' into bugfix/gateway/handler-invalid-argument

Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the bugfix/gateway/handler-invalid-argument branch from 3b52d00 to 40f55d7 Compare May 23, 2022 04:26
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1667 (438342c) into master (39c94df) will decrease coverage by 0.12%.
The diff coverage is 0.81%.

@@            Coverage Diff             @@
##           master    #1667      +/-   ##
==========================================
- Coverage   30.82%   30.69%   -0.13%     
==========================================
  Files         372      372              
  Lines       32395    32502     +107     
==========================================
- Hits         9986     9978       -8     
- Misses      22038    22147     +109     
- Partials      371      377       +6     
Impacted Files Coverage Δ
pkg/gateway/lb/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/handler/grpc/handler.go 13.88% <6.25%> (-0.17%) ⬇️
...ent/core/ngt/service/vqueue/undeleted_index_map.go 66.11% <0.00%> (-5.00%) ⬇️
pkg/agent/core/ngt/service/option.go 91.41% <0.00%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8fae8...438342c. Read the comment docs.

@kpango kpango requested review from kmrmt and hlts2 May 23, 2022 04:57
kmrmt
kmrmt previously approved these changes May 23, 2022
Signed-off-by: kpango <kpango@vdaas.org>
@github-actions
Copy link
Contributor

Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@kpango kpango merged commit e6d9fe5 into master May 23, 2022
@kpango kpango deleted the bugfix/gateway/handler-invalid-argument branch May 23, 2022 08:16
This was referenced May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants