Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pkg test helper functions #1678

Merged
merged 29 commits into from
Jun 2, 2022
Merged

Refactor pkg test helper functions #1678

merged 29 commits into from
Jun 2, 2022

Commits on Jun 1, 2022

  1. refactor charset helper func 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    829b460 View commit details
    Browse the repository at this point in the history

  2. refactor vector helper func 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    743b8b6 View commit details
    Browse the repository at this point in the history

  3. refactor request helper func 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    05f872a View commit details
    Browse the repository at this point in the history

  4. add missing files 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    7e374aa View commit details
    Browse the repository at this point in the history

  5. move charset to conv 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    847bbe2 View commit details
    Browse the repository at this point in the history

  6. return error from helper func 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    a3dc388 View commit details
    Browse the repository at this point in the history

  7. refactor conv helper func 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    7691ea4 View commit details
    Browse the repository at this point in the history

  8. refactor fill() and implement buildIndex() 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    1cddad7 View commit details
    Browse the repository at this point in the history

  9. fix comment 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    90be937 View commit details
    Browse the repository at this point in the history

  10. refactor convertXXX 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    0796dc5 View commit details
    Browse the repository at this point in the history

  11. refactor search test func 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    b5759bd View commit details
    Browse the repository at this point in the history

  12. refactor beforeFunc test func to use buildIndex 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    6964a0e View commit details
    Browse the repository at this point in the history

  13. 🤖 Update license headers / Format go codes and yaml files 

    Signed-off-by: Vdaas CI <vald@vdaas.org>
    @vdaas-ci @kevindiu
    vdaas-ci authored and kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    9cd164c View commit details
    Browse the repository at this point in the history

  14. Revert ":robot: Update license headers / Format go codes and yaml files" 

    This reverts commit a8b44c3.
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    7037415 View commit details
    Browse the repository at this point in the history

  15. format code 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    15ea532 View commit details
    Browse the repository at this point in the history

  16. fix comment 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    1343782 View commit details
    Browse the repository at this point in the history

  17. implement test for helper functions 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    b6a9057 View commit details
    Browse the repository at this point in the history

  18. add comments to helper functions 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    61d76d5 View commit details
    Browse the repository at this point in the history

  19. implement conv test 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    928b4c8 View commit details
    Browse the repository at this point in the history

  20. fix golangci warning 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    9eb32fc View commit details
    Browse the repository at this point in the history

  21. fix comment 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    c203493 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. fix golangci warning 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    c85b54c View commit details
    Browse the repository at this point in the history

  2. split encode() 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    5ad9c5a View commit details
    Browse the repository at this point in the history

  3. implement boundary value test for vector/gen 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    b6591a4 View commit details
    Browse the repository at this point in the history

  4. use io instead of ioutil package 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    f60334a View commit details
    Browse the repository at this point in the history

  5. Update internal/conv/conv_test.go 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @kevindiu @github-actions
    kevindiu and github-actions[bot] authored Jun 2, 2022
    Configuration menu
    Copy the full SHA
    dd4d4f7 View commit details
    Browse the repository at this point in the history

  6. add boundary tests 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    be8dd0b View commit details
    Browse the repository at this point in the history

  7. fix test error 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    082ac19 View commit details
    Browse the repository at this point in the history

  8. add more boundary tests 

    Signed-off-by: kevindiu <kevindiujp@gmail.com>
    @kevindiu
    kevindiu committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    c477b85 View commit details
    Browse the repository at this point in the history