Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement upsert test cases #1685

Merged
merged 8 commits into from
Jun 15, 2022

Conversation

kmrmt
Copy link
Contributor

@kmrmt kmrmt commented Jun 2, 2022

Signed-off-by: Kosuke Morimoto ksk@vdaas.org

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 2, 2022

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #1685 (07a1d4f) into master (35eba88) will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1685      +/-   ##
==========================================
+ Coverage   31.23%   31.47%   +0.23%     
==========================================
  Files         385      385              
  Lines       32679    32679              
==========================================
+ Hits        10208    10285      +77     
+ Misses      22083    22006      -77     
  Partials      388      388              
Impacted Files Coverage Δ
...ent/core/ngt/service/vqueue/undeleted_index_map.go 65.00% <0.00%> (-3.34%) ⬇️
internal/worker/worker.go 83.59% <0.00%> (-1.57%) ⬇️
internal/core/algorithm/ngt/ngt.go 65.35% <0.00%> (+0.65%) ⬆️
pkg/agent/core/ngt/handler/grpc/upsert.go 31.06% <0.00%> (+31.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d97509...07a1d4f. Read the comment docs.

@kmrmt kmrmt force-pushed the test/pkg/implement-agent-ngt-handler-upsert-test branch from c6af945 to 1f39ee0 Compare June 6, 2022 09:57
@kmrmt kmrmt force-pushed the test/pkg/implement-agent-ngt-handler-upsert-test branch from f45ba72 to 4b48f9f Compare June 8, 2022 02:03
kmrmt added 2 commits June 9, 2022 03:59
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt kmrmt force-pushed the test/pkg/implement-agent-ngt-handler-upsert-test branch from 4b48f9f to 2a213d3 Compare June 9, 2022 03:59
@github-actions github-actions bot added size/XXL and removed size/M labels Jun 9, 2022
@kmrmt kmrmt changed the title [WIP] implement upsert test cases implement upsert test cases Jun 9, 2022
@kmrmt kmrmt marked this pull request as ready for review June 9, 2022 04:01
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
pkg/agent/core/ngt/handler/grpc/upsert_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/handler/grpc/upsert_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/handler/grpc/upsert_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/handler/grpc/upsert_test.go Outdated Show resolved Hide resolved
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the test/pkg/implement-agent-ngt-handler-upsert-test branch from 61be2a3 to 225c745 Compare June 13, 2022 12:53
@kpango kpango requested review from a team and datelier and removed request for a team June 14, 2022 05:48
@kpango kpango merged commit 59c0a2c into master Jun 15, 2022
@kpango kpango deleted the test/pkg/implement-agent-ngt-handler-upsert-test branch June 15, 2022 00:03
@kevindiu kevindiu mentioned this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants