Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dataflow docs for new images and using remove instead of delete #1693

Merged

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Jun 7, 2022

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 7, 2022

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

docs/overview/data-flow.md Outdated Show resolved Hide resolved
@vankichi vankichi force-pushed the refactor/docs/update-dataflow-docs-according-to-new-images branch from a8aaf5e to 3c578f3 Compare June 9, 2022 04:26
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the refactor/docs/update-dataflow-docs-according-to-new-images branch from 3c578f3 to 0b43faf Compare June 9, 2022 04:26
@vankichi vankichi changed the title [WIP] update dataflow docs for new images update dataflow docs for new images Jun 9, 2022
@vankichi vankichi marked this pull request as ready for review June 9, 2022 04:27
@vankichi vankichi requested review from kevindiu and kmrmt June 9, 2022 04:27
kmrmt
kmrmt previously approved these changes Jun 9, 2022
@vankichi vankichi force-pushed the refactor/docs/update-dataflow-docs-according-to-new-images branch 2 times, most recently from 0af1900 to bc31d8b Compare June 9, 2022 08:52
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the refactor/docs/update-dataflow-docs-according-to-new-images branch from bc31d8b to c7c8577 Compare June 9, 2022 08:53
@vankichi vankichi changed the title update dataflow docs for new images update dataflow docs for new images and using remove instead of delete Jun 9, 2022
@vankichi vankichi requested a review from kmrmt June 13, 2022 00:48
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi merged commit f6caa92 into master Jun 14, 2022
@vankichi vankichi deleted the refactor/docs/update-dataflow-docs-according-to-new-images branch June 14, 2022 01:30
@kevindiu kevindiu mentioned this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants