Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backoff metrics panel #1694

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Jun 7, 2022

Description:

WHAT

This PR contains the following changes

  • add backoff metrics dashboard
  • add Completed RPCs/Latency panel for LB, Agent
  • fix query (irate->increase) for gc count panel

WHY

We added new feature to get backoff metrics. So we need to create new panel to grafana.
And OSS grafana's dashboard was old, so we need to change the latest.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

hlts2 added 2 commits June 7, 2022 02:27
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 7, 2022

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@hlts2 hlts2 self-assigned this Jun 7, 2022
@hlts2
Copy link
Collaborator Author

hlts2 commented Jun 7, 2022

📝 The following image is result for my local environment.
1

@kpango kpango requested review from kpango and datelier June 7, 2022 04:31
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2
Copy link
Collaborator Author

hlts2 commented Jun 7, 2022

@kpango @datelier
Thank you for your review!
I will merge this PR!

@hlts2 hlts2 merged commit bb9b593 into master Jun 7, 2022
@hlts2 hlts2 deleted the feature/k8s/add-backoff-metrics-dashboard branch June 7, 2022 08:14
@hlts2 hlts2 mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants