Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified design of troubleshooting image #1705

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Conversation

taisuou
Copy link
Contributor

@taisuou taisuou commented Jun 20, 2022

modified some details of troubleshooting image

・use few colors to simplify a impression of the image.
・add glay color to the background to define each blocks.
・outline color (#000000) of rhombus boxes are as standing out as its texts.So changed the black color to gray.

before
スクリーンショット 2022-06-20 13 21

after
スクリーンショット 2022-06-27 14 35 22

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.6

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2022

CLA assistant check
All committers have signed the CLA.

@taisuou
Copy link
Contributor Author

taisuou commented Jun 23, 2022

modified detail and exported svg in these settings below.
スクリーンショット 2022-06-23 17 04 50

@taisuou taisuou force-pushed the design/troubleshooting-fix branch 2 times, most recently from 17ee567 to ab780a0 Compare June 23, 2022 08:31
@taisuou taisuou force-pushed the design/troubleshooting-fix branch from ab780a0 to dffc699 Compare June 23, 2022 08:33
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi merged commit ecbca98 into master Jun 28, 2022
@vankichi vankichi deleted the design/troubleshooting-fix branch June 28, 2022 04:42
kevindiu pushed a commit that referenced this pull request Jul 4, 2022
* modified design of troubleshooting image

* modified troubleshooting image

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
@kevindiu kevindiu mentioned this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants