Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary import path on pkg test #1712

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Jun 23, 2022

Signed-off-by: kevindiu kevindiujp@gmail.com

Description:

Same as title

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.6

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1712 (1403a64) into master (13c0e71) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1712      +/-   ##
==========================================
- Coverage   31.56%   31.55%   -0.02%     
==========================================
  Files         385      385              
  Lines       32713    32713              
==========================================
- Hits        10327    10321       -6     
- Misses      21995    21996       +1     
- Partials      391      396       +5     
Impacted Files Coverage Δ
...ent/core/ngt/service/vqueue/undeleted_index_map.go 68.33% <0.00%> (-2.78%) ⬇️
internal/worker/queue.go 96.20% <0.00%> (-2.54%) ⬇️
pkg/agent/core/ngt/service/option.go 89.57% <0.00%> (-1.85%) ⬇️
internal/worker/worker.go 83.59% <0.00%> (+1.56%) ⬆️
internal/errgroup/group.go 95.00% <0.00%> (+2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c0e71...1403a64. Read the comment docs.

@github-actions github-actions bot added size/M and removed size/S labels Jun 23, 2022
@kevindiu kevindiu requested a review from vankichi June 23, 2022 08:18
Signed-off-by: kevindiu <kevindiujp@gmail.com>
Signed-off-by: kevindiu <kevindiujp@gmail.com>
@kevindiu kevindiu force-pushed the test/pkg/fix-pkg-agent-handler-grpc-import branch from c51fee6 to 1403a64 Compare June 23, 2022 08:21
@kpango kpango merged commit 75e578f into master Jun 27, 2022
@kpango kpango deleted the test/pkg/fix-pkg-agent-handler-grpc-import branch June 27, 2022 04:44
kevindiu added a commit that referenced this pull request Jul 4, 2022
* fix insert test import path

Signed-off-by: kevindiu <kevindiujp@gmail.com>

* update response validation logic

Signed-off-by: kevindiu <kevindiujp@gmail.com>
@kevindiu kevindiu mentioned this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants