Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete tensorflow #1723

Merged
merged 1 commit into from
Jul 6, 2022
Merged

delete tensorflow #1723

merged 1 commit into from
Jul 6, 2022

Conversation

datelier
Copy link
Contributor

@datelier datelier commented Jul 5, 2022

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.6

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@datelier datelier requested review from kpango and hlts2 July 5, 2022 08:00
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 5, 2022

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 5, 2022

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #1723 (8261dd5) into master (9ea85a3) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1723      +/-   ##
==========================================
- Coverage   31.67%   31.60%   -0.08%     
==========================================
  Files         385      371      -14     
  Lines       32713    32264     -449     
==========================================
- Hits        10362    10196     -166     
+ Misses      21955    21679     -276     
+ Partials      396      389       -7     
Impacted Files Coverage Δ
hack/license/gen/main.go 0.00% <ø> (ø)
internal/core/algorithm/ngt/ngt.go 64.70% <0.00%> (-0.66%) ⬇️
internal/worker/worker.go 84.37% <0.00%> (+0.78%) ⬆️
internal/worker/queue.go 100.00% <0.00%> (+1.26%) ⬆️
pkg/agent/core/ngt/service/option.go 91.41% <0.00%> (+1.84%) ⬆️
...ent/core/ngt/service/vqueue/undeleted_index_map.go 71.11% <0.00%> (+6.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c8a6a...8261dd5. Read the comment docs.

Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit fbe44bc into master Jul 6, 2022
@kpango kpango deleted the refactoring/tensorflow/delete branch July 6, 2022 02:44
@hlts2 hlts2 mentioned this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants