Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file name of capacity planning document #1737

Merged

Conversation

vankichi
Copy link
Contributor

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.7

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vankichi vankichi requested review from kevindiu, a team and hlts2 and removed request for a team July 19, 2022 05:46
kpango
kpango previously approved these changes Jul 19, 2022
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kevindiu
kevindiu previously approved these changes Jul 19, 2022
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi dismissed stale reviews from kevindiu and kpango via b650c6a July 19, 2022 05:54
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 19, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1fd37eb
Status: ✅  Deploy successful!
Preview URL: https://20752064.vald.pages.dev
Branch Preview URL: https://documentation-docs-fix-capac-50mx.vald.pages.dev

View logs

kevindiu
kevindiu previously approved these changes Jul 19, 2022
@vankichi vankichi requested a review from kpango July 19, 2022 05:58
kpango
kpango previously approved these changes Jul 19, 2022
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi dismissed stale reviews from kpango and kevindiu via 1fd37eb July 19, 2022 06:00
@vankichi vankichi requested review from kevindiu and kpango July 19, 2022 06:03
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vankichi vankichi merged commit 8038ad7 into master Jul 19, 2022
@vankichi vankichi deleted the documentation/docs/fix-capacity-plannning-document-filename branch July 19, 2022 06:15
@hlts2 hlts2 mentioned this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants