Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add backup configuration document #1754

Merged
merged 13 commits into from
Aug 31, 2022
Merged

add backup configuration document #1754

merged 13 commits into from
Aug 31, 2022

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Aug 1, 2022 •
edited
Loading

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.7

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vankichi
📝 add backup configuration document
3477053 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 1, 2022

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 1, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4f121bf
Status:⚡️  Build in progress...

View logs

@github-actions github-actions bot added size/L and removed size/M labels Aug 1, 2022
github-actions[bot]
github-actions bot reviewed Aug 1, 2022
View reviewed changes
docs/user-guides/backup-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/backup-configuration.md Show resolved Hide resolved
docs/user-guides/backup-configuration.md Show resolved Hide resolved
docs/user-guides/backup-configuration.md Show resolved Hide resolved
docs/user-guides/backup-configuration.md Outdated Show resolved Hide resolved
@vankichi
📝 add sample yaml
a68e0db 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the documentation/docs/add-backup-config-document branch from 1f37ac1 to a68e0db Compare August 1, 2022 06:12
@vankichi vankichi marked this pull request as ready for review August 1, 2022 06:15
@vankichi vankichi requested review from kevindiu, a team and datelier and removed request for a team August 1, 2022 06:16
kevindiu
kevindiu reviewed Aug 2, 2022
View reviewed changes
docs/user-guides/backup-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/backup-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/backup-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/backup-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/backup-configuration.md Outdated Show resolved Hide resolved
vankichi
vankichi commented Aug 2, 2022
View reviewed changes
Copy link
Contributor Author

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevindiu
I have checked the grammar and replied to your suggestion.

docs/user-guides/backup-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/backup-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/backup-configuration.md Outdated Show resolved Hide resolved
vankichi and others added 3 commits August 2, 2022 17:03
@vankichi vankichi requested a review from kevindiu August 2, 2022 23:43
datelier
datelier previously approved these changes Aug 3, 2022
View reviewed changes
kevindiu
kevindiu previously approved these changes Aug 3, 2022
View reviewed changes
@vankichi vankichi requested a review from kpango August 3, 2022 05:53
@vankichi vankichi changed the base branch from master to main August 8, 2022 08:28
@vankichi vankichi dismissed stale reviews from kevindiu and datelier August 8, 2022 08:28

The base branch was changed.

datelier
datelier previously approved these changes Aug 9, 2022
View reviewed changes
kevindiu
kevindiu previously approved these changes Aug 9, 2022
View reviewed changes
@kpango
Copy link
Collaborator

kpango commented Aug 17, 2022

It would be better to add 4 points.

  1. S3, PV, PV+S3 Use Cases and Merit Demerits
  2. Enabling/disabling init-container and its behavior in the case of S3
  3. Advantages and disadvantages of CoW enable/disable
  4. Concept of each setting item for backup?

@vankichi
📝 apply feedback
f3e8469 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi dismissed stale reviews from kevindiu and datelier via f3e8469 August 23, 2022 01:22
@vankichi
📝 apply feedback
3e64f23 
Signed-off-by: vankichi <kyukawa315@gmail.com>
kpango
kpango reviewed Aug 25, 2022
View reviewed changes
docs/user-guides/backup-configuration.md Outdated
# accessMode for PV (please verify your environment)
accessMode: ReadWriteOncePod
# storage class for PV (please verify your environment)
storageClass: local-path
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to set GKE storage class and configuration as a sample.

vankichi and others added 2 commits August 25, 2022 13:28
@vankichi @kpango
Apply suggestions from code review
4f24577 
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
@vankichi
📝 update sample yaml
221fb4f 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@kpango kpango merged commit 44722fd into main Aug 31, 2022
@kpango kpango deleted the documentation/docs/add-backup-config-document branch August 31, 2022 01:03
@kevindiu kevindiu mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@datelier datelier datelier approved these changes

@kpango kpango kpango approved these changes

@kevindiu kevindiu kevindiu approved these changes

Assignees
No one assigned
Labels
priority/low size/L type/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vankichi @vdaas-ci @kpango @kevindiu @datelier