Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add filter config document #1755

Merged
merged 11 commits into from
Aug 17, 2022
Merged

add filter config document #1755

merged 11 commits into from
Aug 17, 2022

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Aug 2, 2022 •
edited
Loading

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.7

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vankichi
📝 create filter config document
67c8304 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 2, 2022

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

github-actions[bot]
github-actions bot reviewed Aug 2, 2022
View reviewed changes
docs/user-guides/filtering-configuration.md Show resolved Hide resolved
docs/user-guides/filtering-configuration.md Show resolved Hide resolved
docs/user-guides/filtering-configuration.md Show resolved Hide resolved
docs/user-guides/filtering-configuration.md Show resolved Hide resolved
docs/user-guides/filtering-configuration.md Show resolved Hide resolved
docs/user-guides/filtering-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/filtering-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/filtering-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/filtering-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/filtering-configuration.md Outdated Show resolved Hide resolved
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 2, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b429d04
Status: ✅  Deploy successful!
Preview URL: https://0d4a25f7.vald.pages.dev
Branch Preview URL: https://documentation-docs-create-fi.vald.pages.dev

View logs

@vankichi
♻️ update sample codes
26b13b7 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the documentation/docs/create-filter-configuration-document branch from db15392 to 26b13b7 Compare August 2, 2022 07:48
@vankichi vankichi changed the title [WIP] create filter config document add filter config document Aug 2, 2022
@vankichi vankichi marked this pull request as ready for review August 2, 2022 07:50
@vankichi vankichi requested review from kevindiu, a team and hlts2 and removed request for a team August 2, 2022 07:50
kevindiu
kevindiu reviewed Aug 3, 2022
View reviewed changes
docs/user-guides/filtering-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/filtering-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/filtering-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/filtering-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/filtering-configuration.md Outdated Show resolved Hide resolved
docs/user-guides/filtering-configuration.md Outdated Show resolved Hide resolved
vankichi and others added 3 commits August 3, 2022 14:32
@vankichi @kevindiu
Apply suggestions from code review
59e2f8c 
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
@vankichi
♻️ update prh.yaml
5eaac22 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi @kevindiu
Apply suggestions from code review
e7bf08a 
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
@vankichi vankichi requested a review from kevindiu August 3, 2022 06:03
kevindiu
kevindiu previously approved these changes Aug 3, 2022
View reviewed changes
hlts2
hlts2 previously approved these changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi requested a review from kpango August 5, 2022 05:08
@vankichi vankichi changed the base branch from master to main August 8, 2022 08:28
@vankichi vankichi dismissed stale reviews from hlts2 and kevindiu August 8, 2022 08:28

The base branch was changed.

@vankichi vankichi requested a review from kevindiu August 8, 2022 23:36
@vankichi vankichi requested a review from hlts2 August 8, 2022 23:36
hlts2
hlts2 previously approved these changes Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi requested review from hlts2 and kpango August 9, 2022 08:14
hlts2
hlts2 approved these changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi closed this Aug 17, 2022
@vankichi vankichi reopened this Aug 17, 2022
@vankichi vankichi merged commit 7df3311 into main Aug 17, 2022
@vankichi vankichi deleted the documentation/docs/create-filter-configuration-document branch August 17, 2022 06:00
@kevindiu kevindiu mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@hlts2 hlts2 hlts2 approved these changes

@kpango kpango kpango approved these changes

@kevindiu kevindiu kevindiu approved these changes

Assignees
No one assigned
Labels
priority/low size/L type/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vankichi @vdaas-ci @kevindiu @kpango @hlts2