-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deployment document #1758
Merged
Merged
add deployment document #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vankichi <kyukawa315@gmail.com>
[CHATOPS:HELP] ChatOps commands.
|
Deploying with Cloudflare Pages
|
vankichi
force-pushed
the
documentation/docs/add-deployment-document
branch
from
August 3, 2022 22:07
667c019
to
5ab2370
Compare
Signed-off-by: vankichi <kyukawa315@gmail.com>
vankichi
force-pushed
the
documentation/docs/add-deployment-document
branch
from
August 3, 2022 22:09
5ab2370
to
4ba86d0
Compare
vankichi
requested review from
kevindiu,
a team and
datelier
and removed request for
a team
August 4, 2022 00:31
kpango
requested changes
Aug 4, 2022
- Monitoring the Vald deployments and Vald custom resource by `vald-helm-operator` | ||
- Use `kubectl` command to set or update of the Vald cluster configuration | ||
- Automate manage the Vald cluster based on CRD (Custom Resource Definitions) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be better to add benefit about wituout Helm command
kevindiu
reviewed
Aug 4, 2022
kevindiu
reviewed
Aug 4, 2022
kevindiu
reviewed
Aug 4, 2022
Co-authored-by: Yusuke Kato <kpango@vdaas.org> Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
kpango
previously approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kpango
approved these changes
Aug 9, 2022
kevindiu
approved these changes
Aug 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vankichi kyukawa315@gmail.com
Description:
SSIA
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: