Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deployment document #1758

Merged
merged 9 commits into from
Aug 9, 2022
Merged

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Aug 3, 2022

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.7

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 3, 2022

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Outdated Show resolved Hide resolved
docs/user-guides/deployment.md Outdated Show resolved Hide resolved
docs/user-guides/deployment.md Outdated Show resolved Hide resolved
docs/user-guides/deployment.md Outdated Show resolved Hide resolved
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 3, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cb1df05
Status: ✅  Deploy successful!
Preview URL: https://5daf58d3.vald.pages.dev
Branch Preview URL: https://documentation-docs-add-deplo.vald.pages.dev

View logs

@vankichi vankichi force-pushed the documentation/docs/add-deployment-document branch from 667c019 to 5ab2370 Compare August 3, 2022 22:07
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the documentation/docs/add-deployment-document branch from 5ab2370 to 4ba86d0 Compare August 3, 2022 22:09
@vankichi vankichi changed the title [WIP] add deployment document add deployment document Aug 4, 2022
@vankichi vankichi requested review from kevindiu, a team and datelier and removed request for a team August 4, 2022 00:31
@vankichi vankichi marked this pull request as ready for review August 4, 2022 00:32
@vankichi vankichi requested review from a team, hlts2, datelier and kpango and removed request for datelier, a team and hlts2 August 4, 2022 00:32
docs/user-guides/deployment.md Outdated Show resolved Hide resolved
- Monitoring the Vald deployments and Vald custom resource by `vald-helm-operator`
- Use `kubectl` command to set or update of the Vald cluster configuration
- Automate manage the Vald cluster based on CRD (Custom Resource Definitions)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better to add benefit about wituout Helm command

docs/user-guides/deployment.md Outdated Show resolved Hide resolved
docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Outdated Show resolved Hide resolved
docs/user-guides/deployment.md Outdated Show resolved Hide resolved
docs/user-guides/deployment.md Outdated Show resolved Hide resolved
docs/user-guides/deployment.md Outdated Show resolved Hide resolved
docs/user-guides/deployment.md Outdated Show resolved Hide resolved
docs/user-guides/deployment.md Outdated Show resolved Hide resolved
docs/user-guides/deployment.md Outdated Show resolved Hide resolved
docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Outdated Show resolved Hide resolved
vankichi and others added 2 commits August 4, 2022 16:58
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Show resolved Hide resolved
docs/user-guides/deployment.md Show resolved Hide resolved
Signed-off-by: vankichi <kyukawa315@gmail.com>
kpango
kpango previously approved these changes Aug 8, 2022
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi changed the base branch from master to main August 8, 2022 08:27
@vankichi vankichi dismissed kpango’s stale review August 8, 2022 08:27

The base branch was changed.

@vankichi vankichi requested a review from kpango August 8, 2022 08:30
@vankichi vankichi merged commit 48cdb52 into main Aug 9, 2022
@vankichi vankichi deleted the documentation/docs/add-deployment-document branch August 9, 2022 08:14
@kevindiu kevindiu mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants