Add crds for continuous benchmark tools #1779

vankichi · 2022-08-25T04:26:38Z

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

I have created the crd and rbac for the continuous benchmark operator.

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.18.3
Docker Version: 20.10.8
Kubernetes Version: 1.22.0
NGT Version: 1.14.7

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

vdaas-ci · 2022-08-25T04:26:54Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - replace the PR body by changelog details
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase main
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

cloudflare-workers-and-pages · 2022-08-25T06:00:41Z

Deploying with Cloudflare Pages

Latest commit:	`efbfd13`
Status:	✅ Deploy successful!
Preview URL:	https://be41f9a1.vald.pages.dev
Branch Preview URL:	https://feature-pkg-apis-internal-cr-u856.vald.pages.dev

View logs

Signed-off-by: vankichi <kyukawa315@gmail.com>

codecov · 2022-08-30T07:55:46Z

Codecov Report

Base: 31.62% // Head: 31.67% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (efbfd13) compared to base (f7ccb94).
Patch has no changes to coverable lines.

Additional details and impacted files

@@                         Coverage Diff                          @@
##           feature/continous-benchmark-tool    #1779      +/-   ##
====================================================================
+ Coverage                             31.62%   31.67%   +0.04%     
====================================================================
  Files                                   377      377              
  Lines                                 32243    32243              
====================================================================
+ Hits                                  10197    10213      +16     
+ Misses                                21650    21638      -12     
+ Partials                                396      392       -4

Impacted Files	Coverage Δ
internal/worker/queue.go	`98.73% <0.00%> (-1.27%)`	⬇️
internal/worker/worker.go	`85.15% <0.00%> (+1.56%)`	⬆️
...nt/core/ngt/service/vqueue/uninserted_index_map.go	`73.22% <0.00%> (+2.73%)`	⬆️
...ent/core/ngt/service/vqueue/undeleted_index_map.go	`73.88% <0.00%> (+5.55%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

internal/k8s/benchmark/job/job.go

internal/k8s/benchmark/operator/operator.go

internal/k8s/benchmark/job/job.go

internal/k8s/benchmark/job/option.go

Signed-off-by: vankichi <kyukawa315@gmail.com>

kpango

Sorry I couldn't find struct which implements k8s.io/apimachinery/pkg/runtime.Object

github-actions · 2022-09-02T03:06:20Z

internal/k8s/benchmark/job/types.go

+	"k8s.io/apimachinery/pkg/runtime"
+)
+
+type BenchmarkJobSpec struct {


🚫 [golangci] _{reported by reviewdog 🐶}
fieldalignment: struct with 104 pointer bytes could be 56 (govet)

github-actions · 2022-09-02T03:06:20Z

internal/k8s/benchmark/job/types.go

+	Port int
+}
+
+type BenchmarkDatasetSpec struct {


🚫 [golangci] _{reported by reviewdog 🐶}
fieldalignment: struct with 48 pointer bytes could be 32 (govet)

github-actions · 2022-09-02T03:06:21Z

internal/k8s/benchmark/job/types.go

+	Type string
+}
+
+type BenchmarkJob struct {


🚫 [golangci] _{reported by reviewdog 🐶}
fieldalignment: struct with 408 pointer bytes could be 400 (govet)

github-actions · 2022-09-02T03:06:22Z

internal/k8s/benchmark/operator/types.go

+	BenchmarkOperatorHealthy   = BenchmarkOperatorStatus("Healthy")
+)
+
+type BenchmarkOperator struct {


🚫 [golangci] _{reported by reviewdog 🐶}
fieldalignment: struct with 328 pointer bytes could be 320 (govet)

github-actions · 2022-09-07T02:39:54Z

internal/k8s/benchmark/job/types.go

+	Port int
+}
+
+type BenchmarkDataset struct {


🚫 [golangci] _{reported by reviewdog 🐶}
fieldalignment: struct with 48 pointer bytes could be 32 (govet)

Signed-off-by: vankichi <kyukawa315@gmail.com>

internal/k8s/benchmark/operator/operator.go

internal/k8s/benchmark/job/job.go

Co-authored-by: Yusuke Kato <kpango@vdaas.org>

hlts2 · 2022-09-08T08:36:14Z

internal/k8s/benchmark/job/job.go

+func New(opts ...Option) BenchmarkJobWatcher {
+	r := new(reconciler)
+	for _, opt := range append(defaultOpts, opts...) {
+		opt(r)


Could you please add error handling for applying option? 🙏

hlts2 · 2022-09-08T08:38:01Z

internal/k8s/benchmark/operator/operator.go

+func New(opts ...Option) BenchmarkOperatorWatcher {
+	r := new(reconciler)
+	for _, opt := range append(defaultOpts, opts...) {
+		opt(r)


Could you please add error handling for applying option? 🙏

hlts2 · 2022-09-08T08:42:17Z

internal/k8s/benchmark/operator/types.go

+	BenchmarkOperatorNotReady  = BenchmarkOperatorStatus("NotReady")
+	BenchmarkOperatorAvailable = BenchmarkOperatorStatus("Available")
+	BenchmarkOperatorHealthy   = BenchmarkOperatorStatus("Healthy")


Suggested change

BenchmarkOperatorNotReady = BenchmarkOperatorStatus("NotReady")

BenchmarkOperatorAvailable = BenchmarkOperatorStatus("Available")

BenchmarkOperatorHealthy = BenchmarkOperatorStatus("Healthy")

BenchmarkOperatorNotReady BenchmarkOperatorStatus = "NotReady"

BenchmarkOperatorAvailable BenchmarkOperatorStatus = "Available"

BenchmarkOperatorHealthy BenchmarkOperatorStatus = "Healthy"

Signed-off-by: vankichi <kyukawa315@gmail.com>

github-actions · 2022-09-08T09:14:54Z

internal/k8s/benchmark/job/job.go

+
+func (r *reconciler) AddListOpts(opt client.ListOption) {}
+
+func (r *reconciler) Reconcile(ctx context.Context, req reconcile.Request) (res reconcile.Result, err error) {


🚫 [golangci] _{reported by reviewdog 🐶}
named return "res" with type "reconcile.Result" found (nonamedreturns)

github-actions · 2022-09-08T09:14:54Z

internal/k8s/benchmark/operator/operator.go

+
+func (r *reconciler) AddListOpts(opt client.ListOption) {}
+
+func (r *reconciler) Reconcile(ctx context.Context, req reconcile.Request) (res reconcile.Result, err error) {


🚫 [golangci] _{reported by reviewdog 🐶}
named return "res" with type "reconcile.Result" found (nonamedreturns)

github-actions bot added area/internal size/XXL type/feature New feature priority/medium labels Aug 25, 2022

vankichi force-pushed the feature/pkg-apis-internal/create-conn-bench-operator-crd branch from 396d183 to b5e87e9 Compare August 25, 2022 06:00

vankichi force-pushed the feature/pkg-apis-internal/create-conn-bench-operator-crd branch 3 times, most recently from 0d347c2 to 031b997 Compare August 29, 2022 03:09

vankichi requested review from datelier, hlts2, kevindiu and kpango August 29, 2022 03:22

vankichi marked this pull request as ready for review August 29, 2022 03:22

vankichi changed the title ~~[WIP] Add crds for continuous benchmark tools~~ Add crds for continuous benchmark tools Aug 29, 2022

✨ add crds for continuous benchmark operator

326e699

Signed-off-by: vankichi <kyukawa315@gmail.com>

vankichi force-pushed the feature/pkg-apis-internal/create-conn-bench-operator-crd branch from 031b997 to 326e699 Compare August 30, 2022 04:20

✨ add benchmark operator/job scheme

1b93007

Signed-off-by: vankichi <kyukawa315@gmail.com>

github-actions bot reviewed Aug 30, 2022

View reviewed changes

✨ rename package names and add doc.go

0f95f1d

Signed-off-by: vankichi <kyukawa315@gmail.com>

kevindiu approved these changes Aug 31, 2022

View reviewed changes

kpango requested changes Sep 1, 2022

View reviewed changes

github-actions bot reviewed Sep 2, 2022

View reviewed changes

vankichi force-pushed the feature/pkg-apis-internal/create-conn-bench-operator-crd branch from 42dce0d to e128f80 Compare September 7, 2022 02:09

github-actions bot reviewed Sep 7, 2022

View reviewed changes

✨ create runtime object

9747e30

Signed-off-by: vankichi <kyukawa315@gmail.com>

vankichi force-pushed the feature/pkg-apis-internal/create-conn-bench-operator-crd branch from e128f80 to 9747e30 Compare September 7, 2022 08:33

vankichi requested a review from kpango September 8, 2022 06:43

vankichi requested a review from kevindiu September 8, 2022 06:43

kpango reviewed Sep 8, 2022

View reviewed changes

internal/k8s/benchmark/operator/operator.go Outdated Show resolved Hide resolved

kpango reviewed Sep 8, 2022

View reviewed changes

internal/k8s/benchmark/job/job.go Outdated Show resolved Hide resolved

Apply suggestions from code review

b115100

Co-authored-by: Yusuke Kato <kpango@vdaas.org>

hlts2 reviewed Sep 8, 2022

View reviewed changes

♻️ apply feedback

efbfd13

Signed-off-by: vankichi <kyukawa315@gmail.com>

kpango approved these changes Sep 8, 2022

View reviewed changes

github-actions bot reviewed Sep 8, 2022

View reviewed changes

hlts2 approved these changes Sep 12, 2022

View reviewed changes

kevindiu approved these changes Sep 12, 2022

View reviewed changes

kpango merged commit 1681a74 into feature/continous-benchmark-tool Sep 12, 2022

kpango deleted the feature/pkg-apis-internal/create-conn-bench-operator-crd branch September 12, 2022 04:50

vankichi restored the feature/pkg-apis-internal/create-conn-bench-operator-crd branch September 17, 2022 08:30

vankichi mentioned this pull request Sep 17, 2022

Add crds for continuous benchmark tools #1789

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add crds for continuous benchmark tools #1779

Add crds for continuous benchmark tools #1779

vankichi commented Aug 25, 2022 •

edited

Loading

vdaas-ci commented Aug 25, 2022

cloudflare-workers-and-pages bot commented Aug 25, 2022 •

edited

Loading

codecov bot commented Aug 30, 2022 •

edited

Loading

kpango left a comment

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 7, 2022

hlts2 Sep 8, 2022

hlts2 Sep 8, 2022

hlts2 Sep 8, 2022

github-actions bot Sep 8, 2022

github-actions bot Sep 8, 2022


		func (r *reconciler) AddListOpts(opt client.ListOption) {}

		func (r *reconciler) Reconcile(ctx context.Context, req reconcile.Request) (res reconcile.Result, err error) {

Add crds for continuous benchmark tools #1779

Add crds for continuous benchmark tools #1779

Conversation

vankichi commented Aug 25, 2022 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vdaas-ci commented Aug 25, 2022

cloudflare-workers-and-pages bot commented Aug 25, 2022 • edited Loading

Deploying with Cloudflare Pages

codecov bot commented Aug 30, 2022 • edited Loading

Codecov Report

kpango left a comment

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 7, 2022

Choose a reason for hiding this comment

hlts2 Sep 8, 2022

Choose a reason for hiding this comment

hlts2 Sep 8, 2022

Choose a reason for hiding this comment

hlts2 Sep 8, 2022

Choose a reason for hiding this comment

github-actions bot Sep 8, 2022

Choose a reason for hiding this comment

github-actions bot Sep 8, 2022

Choose a reason for hiding this comment

vankichi commented Aug 25, 2022 •

edited

Loading

cloudflare-workers-and-pages bot commented Aug 25, 2022 •

edited

Loading

codecov bot commented Aug 30, 2022 •

edited

Loading