Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use gotestfmt instead of tparse #1788

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Sep 13, 2022

Signed-off-by: kpango kpango@vdaas.org

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.19.1
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.7

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 13, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b10a103
Status: ✅  Deploy successful!
Preview URL: https://bcf356d7.vald.pages.dev
Branch Preview URL: https://ci-github-actions-add-gotest.vald.pages.dev

View logs

@kpango kpango force-pushed the ci/github-actions/add-gotestfmt-insteadof-tparse branch 4 times, most recently from 0ee7a4f to 421570c Compare September 13, 2022 09:01
Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the ci/github-actions/add-gotestfmt-insteadof-tparse branch from 421570c to b10a103 Compare September 13, 2022 09:03
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 7b81b5e into main Sep 13, 2022
@kpango kpango deleted the ci/github-actions/add-gotestfmt-insteadof-tparse branch September 13, 2022 12:38
@kevindiu kevindiu mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants