-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster role document #1796
Conversation
[CHATOPS:HELP] ChatOps commands.
|
Deploying with Cloudflare Pages
|
Signed-off-by: kevindiu <kevindiujp@gmail.com>
Signed-off-by: kevindiu <kevindiujp@gmail.com>
Signed-off-by: kevindiu <kevindiujp@gmail.com>
7e0af67
to
290aea1
Compare
Signed-off-by: kevindiu <kevindiujp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the image.
- ❌ Role setting valid?
- ⭕ Is cluster role setting valid?
|
||
In Vald, the index is distributed across the cluster depending on the resource usage of the cluster, it requires settings to grant permission to a specific role to retrieve cluster information on Kubernetes. | ||
|
||
In Vald, the settings are deployed automatically when using helm to deploy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 ?
It seems not logical sentence considering the below links.
could you please re-think sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this sentence to connect the content.
|
||
All of these rules are required to retrieve Nodes and Pods resource usage from [kube-apiserver](https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/) and also used to discover new Vald Agents or Nodes created on the cluster. | ||
|
||
### Cluster role binding settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would you like to describe?
For cluster role binding only discoverer, or overall?
It should be formatted the section title and sentences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed by changing the title
Signed-off-by: kevindiu <kevindiujp@gmail.com>
Signed-off-by: kevindiu <kevindiujp@gmail.com>
|
||
These configurations allow the service account `discoverer` to access different resources in the Kubernetes cluster. | ||
|
||
### Cluster role settings for Vald Discoverer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is little bit logical scheme, why this page shows only discoverer.
It should be mentioned why we describe only discoverer.
User may not understand the flow of the story.
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Signed-off-by: kevindiu <kevindiujp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Signed-off-by: kevindiu <kevindiujp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
* add cluster role document Signed-off-by: kevindiu <kevindiujp@gmail.com> * update flowchat and add cluster role setting for cloud providers Signed-off-by: kevindiu <kevindiujp@gmail.com> * fix grammar Signed-off-by: kevindiu <kevindiujp@gmail.com> * update flowchart Signed-off-by: kevindiu <kevindiujp@gmail.com> * fix comment Signed-off-by: kevindiu <kevindiujp@gmail.com> * fix comment Signed-off-by: kevindiu <kevindiujp@gmail.com> * Update docs/user-guides/cluster-role-binding.md * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * fix comment Signed-off-by: kevindiu <kevindiujp@gmail.com> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * fix image Signed-off-by: kevindiu <kevindiujp@gmail.com> * Update docs/user-guides/cluster-role-binding.md * Update docs/user-guides/cluster-role-binding.md * Update cluster-role-binding.md * fix comment Signed-off-by: kevindiu <kevindiujp@gmail.com> * Update docs/user-guides/cluster-role-binding.md * Update docs/user-guides/cluster-role-binding.md * Update cluster-role-binding.md Signed-off-by: kevindiu <kevindiujp@gmail.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Signed-off-by: kpango <kpango@vdaas.org>
Signed-off-by: kevindiu kevindiujp@gmail.com
Description:
This PR include the following changes:
assets/docs/troubleshooting/troubleshooting.drawio
toassets/docs/troubleshooting/provisioning_flow_chart.drawio
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: