Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix metrics bug #1800

Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Oct 5, 2022

Signed-off-by: kpango kpango@vdaas.org

Description:

v1.6.0 includes rpc status metrics bug, when RPC call succeeds metrics expose the state as Unknown it should be OK Status, so I changed it.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.19.1
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: kpango <kpango@vdaas.org>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Oct 5, 2022

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@github-actions github-actions bot added size/M type/bug Something isn't working priority/medium labels Oct 5, 2022
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 30.02% // Head: 30.02% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (0a180c3) compared to base (7a6936e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1800   +/-   ##
=======================================
  Coverage   30.02%   30.02%           
=======================================
  Files         371      371           
  Lines       34006    33988   -18     
=======================================
- Hits        10209    10205    -4     
+ Misses      23383    23368   -15     
- Partials      414      415    +1     
Impacted Files Coverage Δ
...ernal/net/grpc/interceptor/server/metric/metric.go 0.00% <0.00%> (ø)
...nt/core/ngt/service/vqueue/uninserted_index_map.go 70.49% <0.00%> (-2.74%) ⬇️
internal/errgroup/group.go 93.00% <0.00%> (-2.00%) ⬇️
internal/worker/worker.go 83.07% <0.00%> (ø)
internal/core/algorithm/ngt/ngt.go 63.93% <0.00%> (+0.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏
LGTM

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 5, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0a180c3
Status: ✅  Deploy successful!
Preview URL: https://6d56d470.vald.pages.dev
Branch Preview URL: https://bugfix-metrics-interceptor-a.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Oct 5, 2022

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@kpango kpango merged commit 82458a8 into main Oct 5, 2022
@kpango kpango deleted the bugfix/metrics-interceptor/add-validation-for-handler-error branch October 5, 2022 06:52
@hlts2 hlts2 mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants