Bugfix Circuit Breaker half-open error handling

[hlts2]

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

WHAT

I have deleted counter when flow control error occurred in the half-open state

WHY

Counting up on an internal factor error is wrong.

Related Issue:

How Has This Been Tested?:

Environment:

• Go Version: 1.19.1
• Docker Version: 20.10.8
• Kubernetes Version: 1.22.0
• NGT Version: 1.14.8

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - replace the PR body by changelog details
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase main
• 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	41ec6ca
Status:	✅  Deploy successful!
Preview URL:	https://f66f4a56.vald.pages.dev
Branch Preview URL:	https://bugfix-internal-circuitbreak-e2wr.vald.pages.dev

View logs

[codecov]

Codecov Report

Base: 50.23% // Head: 30.36% // Decreases project coverage by -19.86% ⚠️

Coverage data is based on head (b4dfdb0) compared to base (97eed29).
Patch coverage: 41.04% of modified lines in pull request are covered.

❗ Current head b4dfdb0 differs from pull request most recent head 41ec6ca. Consider uploading reports for the commit 41ec6ca to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1811       +/-   ##
===========================================
- Coverage   50.23%   30.36%   -19.87%     
===========================================
  Files         231      371      +140     
  Lines       13464    34021    +20557     
===========================================
+ Hits         6764    10332     +3568     
- Misses       6499    23266    +16767     
- Partials      201      423      +222     

Impacted Files	Coverage Δ
cmd/tools/cli/loadtest/main.go	0.00% <ø> (ø)
hack/benchmark/assets/x1b/loader.go	0.00% <ø> (ø)
hack/benchmark/internal/assets/dataset.go	0.00% <ø> (ø)
hack/benchmark/internal/operation/insert.go	0.00% <ø> (ø)
hack/benchmark/internal/operation/operation.go	0.00% <ø> (ø)
hack/benchmark/internal/operation/option.go	0.00% <ø> (ø)
hack/benchmark/internal/operation/remove.go	0.00% <ø> (ø)
hack/benchmark/internal/operation/search.go	0.00% <ø> (ø)
hack/benchmark/internal/operation/util.go	0.00% <ø> (ø)
hack/license/gen/main.go	0.00% <0.00%> (ø)
... and 247 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[kpango]

LGTM

[kpango]

LGTM