Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix prometheus export return value #1817

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Oct 24, 2022

Signed-off-by: kpango kpango@vdaas.org

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: kpango <kpango@vdaas.org>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 30.34% // Head: 30.36% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (420575b) compared to base (80c42fc).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1817      +/-   ##
==========================================
+ Coverage   30.34%   30.36%   +0.01%     
==========================================
  Files         371      371              
  Lines       34033    34033              
==========================================
+ Hits        10328    10334       +6     
+ Misses      23285    23279       -6     
  Partials      420      420              
Impacted Files Coverage Δ
internal/io/copy.go 62.50% <ø> (ø)
internal/net/grpc/option.go 4.74% <ø> (ø)
...al/observability/exporter/prometheus/prometheus.go 0.00% <0.00%> (ø)
internal/observability/metrics/version/version.go 0.00% <ø> (ø)
...ent/sidecar/usecase/initcontainer/initcontainer.go 0.00% <ø> (ø)
...ent/core/ngt/service/vqueue/undeleted_index_map.go 68.33% <0.00%> (-2.78%) ⬇️
internal/worker/worker.go 82.30% <0.00%> (ø)
internal/errgroup/group.go 95.00% <0.00%> (+1.00%) ⬆️
...nt/core/ngt/service/vqueue/uninserted_index_map.go 78.68% <0.00%> (+5.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hlts2
hlts2 previously approved these changes Oct 24, 2022
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: kpango <kpango@vdaas.org>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 24, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9026bd3
Status: ✅  Deploy successful!
Preview URL: https://2baa0f39.vald.pages.dev
Branch Preview URL: https://bugfix-internal-prometheus.vald.pages.dev

View logs

Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 4ccb63f into main Oct 24, 2022
@kpango kpango deleted the bugfix/internal/prometheus branch October 24, 2022 06:59
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants