Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepsource RVV-B0013 Unused method receiver #1832

Merged
merged 5 commits into from
Nov 18, 2022

Conversation

kevindiu
Copy link
Contributor

Signed-off-by: kevindiu kevindiujp@gmail.com

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

Signed-off-by: kevindiu <kevindiujp@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 50.23% // Head: 30.57% // Decreases project coverage by -19.65% ⚠️

Coverage data is based on head (eea89a7) compared to base (97eed29).
Patch coverage: 32.91% of modified lines in pull request are covered.

❗ Current head eea89a7 differs from pull request most recent head 43bbb44. Consider uploading reports for the commit 43bbb44 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1832       +/-   ##
===========================================
- Coverage   50.23%   30.57%   -19.66%     
===========================================
  Files         231      367      +136     
  Lines       13464    33777    +20313     
===========================================
+ Hits         6764    10329     +3565     
- Misses       6499    23039    +16540     
- Partials      201      409      +208     
Impacted Files Coverage Δ
cmd/tools/cli/loadtest/main.go 0.00% <ø> (ø)
hack/benchmark/assets/x1b/loader.go 0.00% <ø> (ø)
hack/benchmark/internal/assets/dataset.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/insert.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/operation.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/option.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/remove.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/search.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/util.go 0.00% <ø> (ø)
...ck/benchmark/internal/starter/gateway/vald/vald.go 0.00% <0.00%> (ø)
... and 267 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 17, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7b5127e
Status:⚡️  Build in progress...

View logs

vankichi
vankichi previously approved these changes Nov 17, 2022
hlts2
hlts2 previously approved these changes Nov 17, 2022
@kpango kpango dismissed stale reviews from hlts2 and vankichi via 43bbb44 November 18, 2022 05:35
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 2f6efde into main Nov 18, 2022
@kpango kpango deleted the refactor/RVV-B0013/unused-method-receiver branch November 18, 2022 05:40
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants