Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepsource: dockerfile warning #1835

Merged
merged 12 commits into from
Nov 18, 2022
Merged

Fix deepsource: dockerfile warning #1835

merged 12 commits into from
Nov 18, 2022

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Nov 17, 2022

Description:

WHAT

refactored Dockerfile

WHY

There ware a lot of deepsource warning

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 17, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0a52243
Status: ✅  Deploy successful!
Preview URL: https://832e4a32.vald.pages.dev
Branch Preview URL: https://refactor-dockerfile.vald.pages.dev

View logs

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@github-actions github-actions bot added size/M and removed size/S labels Nov 17, 2022
@hlts2 hlts2 changed the title Refactor dockerfile based on deepsource warning Fix deepsource: dockerfile warning Nov 17, 2022
@hlts2 hlts2 marked this pull request as ready for review November 18, 2022 02:00
kpango
kpango previously approved these changes Nov 18, 2022
kpango and others added 2 commits November 18, 2022 14:37
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 requested a review from kpango November 18, 2022 05:54
@github-actions
Copy link
Contributor

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@hlts2 hlts2 merged commit 77206ca into main Nov 18, 2022
@hlts2 hlts2 deleted the refactor/dockerfile branch November 18, 2022 08:29
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants