Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deepsource: Unsafe defer of os.Close #1836

Merged
merged 3 commits into from
Nov 18, 2022
Merged

fix deepsource: Unsafe defer of os.Close #1836

merged 3 commits into from
Nov 18, 2022

Conversation

datelier
Copy link
Contributor

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 17, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 31bf8f0
Status: ✅  Deploy successful!
Preview URL: https://3e727902.vald.pages.dev
Branch Preview URL: https://refactoring-go-s2307-unsafe-.vald.pages.dev

View logs

hlts2
hlts2 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 8e7980a into main Nov 18, 2022
@kpango kpango deleted the refactoring/GO-S2307/unsafe-defer-of-os-Close branch November 18, 2022 05:32
@kpango kpango mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpango kpango kpango left review comments

@hlts2 hlts2 hlts2 approved these changes

@vankichi vankichi vankichi approved these changes

@kevindiu kevindiu kevindiu approved these changes

Assignees
No one assigned
Labels
priority/low size/S team/set SET team type/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@datelier @vdaas-ci @kevindiu @kpango @vankichi @hlts2