Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepsource: GSC-G404 Audit the random number generation source (rand) #1839

Conversation

datelier
Copy link
Contributor

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 30.55% // Head: 30.54% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (63e47de) compared to base (63e6fcd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1839      +/-   ##
==========================================
- Coverage   30.55%   30.54%   -0.01%     
==========================================
  Files         367      367              
  Lines       33777    33777              
==========================================
- Hits        10320    10317       -3     
- Misses      23043    23047       +4     
+ Partials      414      413       -1     
Impacted Files Coverage Δ
internal/test/data/vector/gen.go 93.40% <100.00%> (ø)
...ent/core/ngt/service/vqueue/undeleted_index_map.go 71.11% <0.00%> (-5.56%) ⬇️
internal/worker/queue.go 98.73% <0.00%> (-1.27%) ⬇️
internal/errgroup/group.go 94.00% <0.00%> (-1.00%) ⬇️
internal/worker/worker.go 82.30% <0.00%> (ø)
...nt/core/ngt/service/vqueue/uninserted_index_map.go 73.22% <0.00%> (+4.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vankichi vankichi changed the title fix deepsource: Audit the random number generation source (rand) Fix deepsource: GSC-G404 Audit the random number generation source (rand) Nov 17, 2022
@vankichi vankichi merged commit b36a6c4 into main Nov 17, 2022
@vankichi vankichi deleted the refactoring/GSC-G404/audit-the-random-number-generation-source-rand branch November 17, 2022 08:57
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants