-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deepsource: RVV-B0011 exported function returning value of unexported type #1848
Fix deepsource: RVV-B0011 exported function returning value of unexported type #1848
Conversation
…xported type Signed-off-by: vankichi <kyukawa315@gmail.com>
[CHATOPS:HELP] ChatOps commands.
|
[WARNING:INTCFG] Changes in |
Codecov ReportBase: 30.54% // Head: 30.52% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1848 +/- ##
==========================================
- Coverage 30.54% 30.52% -0.03%
==========================================
Files 367 367
Lines 33833 33833
==========================================
- Hits 10335 10328 -7
- Misses 23086 23091 +5
- Partials 412 414 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Deploying with Cloudflare Pages
|
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ng-value-of-unxported-type
…ng-value-of-unxported-type
Description:
I have fixed the
RVV-B0011
.Fixing the issue, required changing the test code at the
internal/cache
package.I have changed the
checkFunc
to ensure comparingstruct
which satisfies theCache
interface instead of usinggo-cmp
.The code is like:
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: