Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepsource: GSC-G103 Function call made to an unsafe package #1850

Merged

Conversation

datelier
Copy link
Contributor

Description:

Ignore this rule.

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 30.52% // Head: 30.53% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (cb667bf) compared to base (91fb575).
Patch coverage: 27.77% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1850   +/-   ##
=======================================
  Coverage   30.52%   30.53%           
=======================================
  Files         367      367           
  Lines       33797    33833   +36     
=======================================
+ Hits        10317    10330   +13     
- Misses      23068    23089   +21     
- Partials      412      414    +2     
Impacted Files Coverage Δ
hack/benchmark/assets/x1b/loader.go 0.00% <ø> (ø)
internal/net/grpc/grpcconns.go 0.00% <0.00%> (ø)
pkg/discoverer/k8s/service/nodemap.go 0.00% <0.00%> (ø)
pkg/discoverer/k8s/service/nodemetricsmap.go 0.00% <0.00%> (ø)
pkg/discoverer/k8s/service/podmetricsmap.go 0.00% <0.00%> (ø)
pkg/discoverer/k8s/service/podsmap.go 0.00% <0.00%> (ø)
pkg/manager/index/service/indexinfos.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/service/kvs/ou.go 36.11% <33.33%> (-0.05%) ⬇️
pkg/agent/core/ngt/service/kvs/uo.go 56.42% <33.33%> (-0.40%) ⬇️
internal/conv/conv.go 71.05% <50.00%> (-5.62%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vankichi vankichi changed the title fix deepsource: Function call made to an unsafe package Fix deepsource: Function call made to an unsafe package Nov 21, 2022
@vankichi vankichi changed the title Fix deepsource: Function call made to an unsafe package Fix deepsource GSC-G103: Function call made to an unsafe package Nov 21, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 21, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cb667bf
Status: ✅  Deploy successful!
Preview URL: https://c44aad90.vald.pages.dev
Branch Preview URL: https://refactoring-gsc-g103-functio.vald.pages.dev

View logs

@vankichi vankichi changed the title Fix deepsource GSC-G103: Function call made to an unsafe package Fix deepsource: GSC-G103 Function call made to an unsafe package Nov 21, 2022
@vankichi vankichi merged commit f6f55f9 into main Nov 21, 2022
@vankichi vankichi deleted the refactoring/GSC-G103/function-call-made-to-an-unsafe-package branch November 21, 2022 07:36
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants