Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deepsource: [CRT-D0007] Duplicate cases found in switch statement #1851

Merged

Conversation

datelier
Copy link
Contributor

@datelier datelier commented Nov 21, 2022

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@datelier datelier changed the title fix deepsource: Duplicate cases found in switch statement fix deepsource: [CRT-D0007] Duplicate cases found in switch statement Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 30.52% // Head: 30.52% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b9179d9) compared to base (7cad745).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1851   +/-   ##
=======================================
  Coverage   30.52%   30.52%           
=======================================
  Files         367      367           
  Lines       33823    33823           
=======================================
+ Hits        10324    10325    +1     
+ Misses      23086    23085    -1     
  Partials      413      413           
Impacted Files Coverage Δ
internal/file/file.go 11.93% <0.00%> (ø)
...nt/core/ngt/service/vqueue/uninserted_index_map.go 70.43% <0.00%> (-2.69%) ⬇️
internal/net/http/middleware/timeout.go 91.11% <0.00%> (-2.23%) ⬇️
internal/worker/worker.go 81.53% <0.00%> (-1.54%) ⬇️
internal/net/dialer.go 78.40% <0.00%> (+0.99%) ⬆️
internal/worker/queue.go 100.00% <0.00%> (+1.26%) ⬆️
...ent/core/ngt/service/vqueue/undeleted_index_map.go 71.03% <0.00%> (+2.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 21, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b9179d9
Status: ✅  Deploy successful!
Preview URL: https://fca149f1.vald.pages.dev
Branch Preview URL: https://refactoring-crt-d0007-duplic.vald.pages.dev

View logs

@vankichi vankichi merged commit 31b1abf into main Nov 21, 2022
@vankichi vankichi deleted the refactoring/CRT-D0007/duplicate-cases-found-in-switch-statement branch November 21, 2022 10:33
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants