Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepsource: SCC-S1003 replace call to strings.Index with strings.Contains #1853

Conversation

vankichi
Copy link
Contributor

Description:

I have fixed SCC-S1003

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

…gs.Contains

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 30.57% // Head: 30.52% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (fcd1f33) compared to base (dd6045c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1853      +/-   ##
==========================================
- Coverage   30.57%   30.52%   -0.05%     
==========================================
  Files         367      367              
  Lines       33823    33823              
==========================================
- Hits        10341    10326      -15     
- Misses      23072    23081       +9     
- Partials      410      416       +6     
Impacted Files Coverage Δ
internal/info/info.go 88.35% <100.00%> (ø)
...nt/core/ngt/service/vqueue/uninserted_index_map.go 70.43% <0.00%> (-8.61%) ⬇️
...ent/core/ngt/service/vqueue/undeleted_index_map.go 68.30% <0.00%> (-3.28%) ⬇️
internal/worker/worker.go 83.84% <0.00%> (+0.76%) ⬆️
internal/net/dialer.go 78.40% <0.00%> (+0.99%) ⬆️
pkg/agent/core/ngt/service/option.go 91.41% <0.00%> (+1.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 21, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fcd1f33
Status: ✅  Deploy successful!
Preview URL: https://2fb2651f.vald.pages.dev
Branch Preview URL: https://refactor-scc-s1003-replace-c.vald.pages.dev

View logs

@vankichi vankichi merged commit d7345dc into main Nov 21, 2022
@vankichi vankichi deleted the refactor/SCC-S1003/replace-call-to-string-index-with-strings-contains branch November 21, 2022 15:30
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants