Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsing undefined varibale at maxDimensionTest #1856

Merged

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Nov 22, 2022

Description:

I have fixed the using a defined variable instead of an undefined variable in MaxDimensionTest.
It means I use the algorithm.MaximumVectorDimensionSize instead of ngt.VecotrDimensionSizeLimit.

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 22, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c219a44
Status: ✅  Deploy successful!
Preview URL: https://b5b7e37e.vald.pages.dev
Branch Preview URL: https://bugfix-tests-fix-using-undef.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@github-actions github-actions bot added team/set SET team size/S type/bug Something isn't working priority/medium labels Nov 22, 2022
@vankichi vankichi merged commit fbeb0e3 into main Nov 22, 2022
@vankichi vankichi deleted the bugfix/tests/fix-using-undefined-variable-at-max-dim-test branch November 22, 2022 02:05
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/medium size/S team/set SET team type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants